Repository navigation
Conversation
Nexus progress is one more kind of carried state on the shared Workflow Task hook. It keeps its keying by scheduled event ID, its rate limit and its nexus_operation_progress field.
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR folds Nexus operation progress onto the caller's next Workflow Task scheduled event, as one more kind of carried state on Jetty's Workflow Task hook (moetemp/temporal#55).
nexusProgressCarrierjoinstaskCarriers. The hook's rules apply: one follow-up task, no progress on a heartbeat task or its retry, the failover hold.TaskCarriedIndexkeyed by scheduled event ID. The event lists progress by scheduled event ID, not by key order.nexusoperation.progressMinInterval(1 s) rate-limits tasks that progress schedules.It replaces the Bridge half of moetemp/temporal#39. The hook, the heartbeat hold and the failover hold now live in Jetty.
Why?
Progress rides the scheduled event (DD-34), and a burst costs at most one extra task (DD-55). SDKs replay a heartbeat chain differently from live, so progress there could land in another activation (DD-52).
How did you test it?
Link to a test plan if any -
Functional
TestNexusOperationProgress*on both caller kinds,TestNexusProgressAcrossFailoverConversion, and the xdcTestNexusProgressForwardingSuite.