Repository navigation
Conversation
A Workflow closes a stream it owns durably only through the __temporal_system endpoint. Attach, detach and notify take their namespace from the Workflow and go to the notifier in process. A stream reference without its first run is refused on this path too.
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR exposes the stream notifier's writes as
__temporal_systemSystem Nexus operations.streamnotifier.SystemNexusHandlerreuses the frontend's checks and fills the namespace from the Workflow. It calls the notifier in process.TestStreamNotifierClosedFromWorkflowcomes back.It replaces the Bridge half of moetemp/temporal#42. Forwarding, the xdc test and the owner check tests went to Jetty js4 (moetemp/temporal#52). moetemp/temporal#41 and #48 moved to Jetty whole and have no Bridge v2 layer.
Why?
System Nexus lets the generated bindings call the notifier (DD-79).
How did you test it?
Link to a test plan if any -
nexus_service_test.goand functionalTestStreamNotifierClosedFromWorkflow.