Repository navigation
Conversation
A Worker that names a progress operation gets the source's progress through matching, and keeps a cursor on the callback (DD-110, DD-112).
1 of 3 tasks
A follower that stays behind on a busy stream answered each delivery with behind, so it got a new OnProgress at once with no rate bound. The gap defaults to one second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR delivers progress to a
NexusHandlercallback that names a progress operation, as a sync Nexus task on the Worker's task queue.variantProgressDeliveryreturnsdeliverNexusHandlerProgresswhenprogress_operationis set. The fold and backoff are the shared machine's.OnProgressResponsegives the new receiver state. A refusal turns progress off, and retryable errors retry. No result counts against the circuit breaker.behindset, the same progress goes again aftercallback.nexusHandler.progressBehindInterval(1 s), unless newer progress replaced it.callback.nexusHandler.receiverStateMaxSizecaps the state at 8 KiB.It replaces moetemp/temporal#44, ported onto Jetty's delivery seam.
Why?
One progress path serves both callback variants, and a slow follower can't hold back completions (DD-110).
behindlets a Worker read a long backlog in pages that fit the request timeout (DD-112).How did you test it?
Link to a test plan if any -
TestNexusHandlerProgressDeliveryinprogress_nexus_test.go.