Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR tells the Nexus handler the caller namespace on
ExecuteSyncNexusOperation.temporal-caller-namespaceto the authorized request namespace.nexus_headergetsInvalidArgument, in any case spelling.Why?
The stream service's
authorizehook can then key its rules on a verified caller (DD-164 in the direct reads design). Python shows the value asStreamAccess.caller_namespace.The design leaves the HTTP route unchanged. That's not enough, because a client of the HTTP route, or a Workflow's
nexus_header, could set the header too. So this PR removes it there. Setting it on the Workflow path later is a change in the same place.How did you test it?
Link to a test plan if any -
Unit tests in
service/frontend/nexus_sync_test.goandnexus_handler_test.go. Functional tests intests/nexus_sync_test.gocheck that the handler sees the caller namespace, that a client value is refused, and that the HTTP route removes a forged value.