Draft
Conversation
new interface to train MACE models - all MACE CLI options should be available - atomic energies are passed straight into the MACE model (all elements are required to work) - the training dir is more important, and is updated automatically (no more save model) - we keep all MACE output (log files, older models/checkpoints) - training runs automatically restart from the previous model - work with the classmethods
- remove atomic_energies - rely on MACECalculator
- hamiltonians are now immutable - removed excess future creation in .parameters() calls - changed the API for EinsteinCrystal and Harmonic - equality comparisons will break if instance attributes are futures
the 'inputs' kwarg set by partial was overwritten by later code -> change to 'wait_for' keyword
we use the torchrun thingie, which limits us to single-node training
'restart_latest' is really meant to continue an unfinished training run with 'foundation_model' you can start a new training run from an older model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplementation of the psiflow MACE interface to reduce coupling with external libraries. Updates to MACE v0.3.15 and a recent PyTorch version. Also removes the
Modelabstraction asMACEis the only implementation right now. It can be reintroduced later.USAGE
While the
MACEclass is rewritten, most of the interface should be similar/intuitive. Users should only interact with public class/instance methods (see here), e.g.:A
MACEinstance occupies a folder on disk in which it stores all information (models, checkpoints, logs), structured as follows:which is a slight modification of the default MACE folder structure. Only
config.yaml,last.modelandlast.ptare psiflow files; everything else is standard MACE.Some notable changes:
last.pt) by defaultMACEinstance root dir is updated automatically after training (no manual saving)atomic_energieslayer - make sure to define them for every element in your training setHamiltonian
The
MACEHamiltonian/MACEFunctionimplementation now relies on the MACE-ASE calculator. To access new MACE inference features (multi-head evaluation, CuEquivariance, ...), check the latest implementation. You can specify these options in theMACEHamiltonian:Foundation models can be used through the
MACEHamiltonian.from_foundation()method.INSTALLATION
A lot of packages/dependencies have been updated since
v4.0.0-final. An updated installation script can be found under psiflow/install_local.sh. It might need minor tweaks to work.OTHER CHANGES
Some
Functionsubclasses have been slightly updated, but this does not impact usage. TheEinsteinCrystalandHarmonichamiltonians have minor API changes.KNOWN LIMITATIONS
MACE models are not stateless (ACEsuit/mace#1415), meaning checkpoints are not truly interchangeable. If training fails - e.g., due to walltime - you will have checkpoints for the run, but no correct model to load them into.