Skip to content

fix(login): make UI logic flow between Sign Up and Sign In the same (@AzureNightlock)#7628

Closed
AzureNightlock wants to merge 1 commit intomonkeytypegame:masterfrom
AzureNightlock:fix/login-ui-logic-consistency
Closed

fix(login): make UI logic flow between Sign Up and Sign In the same (@AzureNightlock)#7628
AzureNightlock wants to merge 1 commit intomonkeytypegame:masterfrom
AzureNightlock:fix/login-ui-logic-consistency

Conversation

@AzureNightlock
Copy link
Contributor

Description

This PR: Fixes the difference in UI logic flow between Sign Up and Sign In.

  • Added a new signUp class to the sign-up button in the login.html to match the existing signIn class.

  • Added cursor: pointer for the "Remember me" checkbox.

  • Added loginForm state.

  • Added helper functions for sign-in button state: enableSignInButton and disableSignInButton.

  • Made the sign-up button qs more specific by using the signUp class.

  • Renamed isFormComplete to isRegisterFormComplete and added isLoginFormComplete.

  • Added update for Sign In(updateSignInButton()).

  • Added SignInData and getSignInData.

  • Updated getSignUpData to use isRegisterFormComplete.

  • Connected the login email and password fields so the sign-in button updates as the user types.

  • Updated Google and GitHub sign-in flows to disable/re-enable the sign-in button instead of the sign-up button.

  • Updated the regular login flow to use the new sign-in form data and button logic.

Checks

  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 11, 2026
@fehmer
Copy link
Member

fehmer commented Mar 11, 2026

hi @AzureNightlock , thank you for your contribution.

We are currently migrating the login page to solidjs #7595 and #7605

@AzureNightlock
Copy link
Contributor Author

Ahh, Thanks for the heads up! Once the SolidJS login migration is ready, I'd be happy to reapply the same behavior if that would still be helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants