fix(login): make UI logic flow between Sign Up and Sign In the same (@AzureNightlock)#7628
Closed
AzureNightlock wants to merge 1 commit intomonkeytypegame:masterfrom
Closed
Conversation
Member
|
hi @AzureNightlock , thank you for your contribution. We are currently migrating the login page to solidjs #7595 and #7605 |
Contributor
Author
|
Ahh, Thanks for the heads up! Once the SolidJS login migration is ready, I'd be happy to reapply the same behavior if that would still be helpful? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR: Fixes the difference in UI logic flow between Sign Up and Sign In.
Added a new signUp class to the sign-up button in the login.html to match the existing signIn class.
Added cursor: pointer for the "Remember me" checkbox.
Added loginForm state.
Added helper functions for sign-in button state: enableSignInButton and disableSignInButton.
Made the sign-up button qs more specific by using the signUp class.
Renamed isFormComplete to isRegisterFormComplete and added isLoginFormComplete.
Added update for Sign In(updateSignInButton()).
Added SignInData and getSignInData.
Updated getSignUpData to use isRegisterFormComplete.
Connected the login email and password fields so the sign-in button updates as the user types.
Updated Google and GitHub sign-in flows to disable/re-enable the sign-in button instead of the sign-up button.
Updated the regular login flow to use the new sign-in form data and button logic.
Checks