feat: expose moq-relay as library#1121
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis PR refactors rs/moq-relay into an embeddable crate by adding 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@rs/moq-relay/src/web.rs`:
- Line 81: The public Rustdoc comment "Run a HTTP server using Axum" has a
grammar issue; update the doc comment above the HTTP server entrypoint (the
Rustdoc for the function that starts the server in web.rs) to use correct
wording such as "Runs an HTTP server using Axum" or "Run an HTTP server using
Axum" (use "an HTTP server") so the public-facing documentation is grammatically
correct.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 54bf9888-6e4b-4ff4-ae10-9e908f4d794c
📒 Files selected for processing (8)
rs/moq-relay/Cargo.tomlrs/moq-relay/src/auth.rsrs/moq-relay/src/cluster.rsrs/moq-relay/src/config.rsrs/moq-relay/src/connection.rsrs/moq-relay/src/lib.rsrs/moq-relay/src/main.rsrs/moq-relay/src/web.rs
| } | ||
|
|
||
| // Run a HTTP server using Axum | ||
| /// Run a HTTP server using Axum |
There was a problem hiding this comment.
Fix grammar in public Rustdoc.
Line 81 should use “an HTTP server” (or “Runs an HTTP server”) for correct public-facing docs.
Suggested wording tweak
-/// Run a HTTP server using Axum
+/// Runs an HTTP server using Axum.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| /// Run a HTTP server using Axum | |
| /// Runs an HTTP server using Axum. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@rs/moq-relay/src/web.rs` at line 81, The public Rustdoc comment "Run a HTTP
server using Axum" has a grammar issue; update the doc comment above the HTTP
server entrypoint (the Rustdoc for the function that starts the server in
web.rs) to use correct wording such as "Runs an HTTP server using Axum" or "Run
an HTTP server using Axum" (use "an HTTP server") so the public-facing
documentation is grammatically correct.
… cargo commands Mark all public config structs in moq-relay as non_exhaustive so new fields can be added without a semver-breaking change. Remove --quiet from cargo commands in the justfile for better CI debuggability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Luke Curley <kixelated@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Luke Curley <kixelated@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Allows to embed a moq-relay into other binaries. Exposes all things needed to run this embedded in another app.
Doc comments for public items written by Claude, I did a review and couldn't spot anything wrong, but maybe you want to review them yourself once more.