Open
Conversation
2833ba5 to
118ee34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuggestClientthat calls the Merino/api/v1/suggestendpoint and is exposed to iOS and Android through UniFFIsuggestsubcommand tomerino-clifor local testing.Changes
SuggestClient: the public UniFFI object exposed to iOS/Android. Takes aSuggestConfig(optional base host override) and exposes aget_suggestions(query, options)method that returns the raw JSON response body as a string.SuggestOptions: a UniFFI record mapping all merino suggest query parameters (providers, source, country, region, city, client_variants, request_type, accept_language). All fields are optional and omitted fields are not sent.send_syncwith an OHTTP channel ( "merino")QA
cargo test -p merino suggestcargo run -p merino-cli -- suggest --query "apple"cargo run --bin merino-cli -- recommendations --user-agent "my-cli/1.0" --json '{ "locale": "en", "region": "US", "count": 4, "topics": ["tech"], "feeds": ["sections"] }'Pull Request checklist
[ci full]to the PR title.