Repository navigation
Conversation
t/critic.t failed in CI: the extension added hand-written character classes, a `no warnings`, and a `$+[0]` above the counts in t/.perlcritic-history. - Use POSIX classes with /a, which match the same ASCII characters. - Capture the comment text in the front matter regex instead of reading $+[0]. - Drop `no warnings 'redefine'`: nothing defines Bugzilla::Comment::hackbot before the extension does.
Attachment, duplicate and other typed comments are formatted without the comment_body_full hook, so a front matter block in them stayed visible while the header still showed the agent and hid its tag. Only plain comments are parsed now. The DB test adds an attachment with a block in its comment.
|
It looks like the current test failures are not related to the code. @dklawren Please trigger rerun later. I don’t have permission to do it. |
Saving an inline edit put the HTML of the raw text in the page, so a Hackbot comment showed its front matter block until reload. The response is now rendered from body_full, which applies the comment_body_full hook, like the bug page.
| flex-wrap: wrap; | ||
| gap: 4px 0; | ||
| width: 128px; | ||
| width: 64px; |
There was a problem hiding this comment.
this narrows the action group and drops the row gap for every comment on small screens, not just hackbot ones. tag/reply/spinner (and private for insiders) now wrap two per row with no spacing. could this move to hackbot.css scoped to hackbot comments, or is the global change intended
| } | ||
| else { | ||
| $body = $self->body; | ||
| Bugzilla::Hook::process('comment_body_full', |
There was a problem hiding this comment.
with this hook the rest text field (and show.xml thetext, webhook/pulse body) can now omit part of the stored text. docs/en/md/api/core/v1/comment.md still says text is the full body. worth a line there saying extensions may hide parts of text and raw_text always has the stored text
Bug 2086124 - [HACKBOT] Structured metadata on comments
hackbot_useradmin param to enable this feature