Repository navigation
Bug 2090102 - #2826
Merged
Merged
Bug 2090102#2826
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change that masks password hashes in user-update API responses.
No open issues 🎉
What changed in this PR
This PR prevents updated password hashes from being exposed in user-update API responses and adds a regression assertion for the masked value.
Changes:
- Replace the returned
cryptpasswordadded value with******. - Assert that password changes return an empty removed value and a masked added value.
| File | Description |
|---|---|
qa/t/rest_user_update_credentials.t |
Adds an assertion that the response does not return the password hash. |
Bugzilla/API/V1/UserObject.pm |
Masks the updated password hash in API change responses. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review+ carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2090102