Repository navigation
Conversation
…ource Reverts ef9e9b0: the native login accepts ?api_key= since bug 2073282, so /rest/jobqueue_status?api_key=<key> works again (now tested). rest_legacy_credentials.t moves to /rest/component-watching, still legacy.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands the native
Bugzilla::API::V1::Bugzillacontroller (/rest/version,/extensions,/timezone,/time,/jobqueue_status), reverted in ef9e9b0 because a monitoring service calls/rest/jobqueue_statuswith?api_key=<key>.That call works on native routes since 2073282 (deprecated
?api_key=/?Bugzilla_api_key=fallback in the native login), so the original change comes back unchanged. Last core resource of 2057358: only extension endpoints remain on the legacy REST server.Changes
Bugzilla/API/V1/Bugzilla.pm(GET+OPTIONSon the 5 paths, same responses as before)Bugzilla/WebService/Bugzilla.pm,Resources/Bugzilla.pmand theBugzilladispatch entryWS_DISPATCHnow only holds the extensions registered through thewebservicehook;Bugzilla/WebService.pmPOD updated accordingly.qa/t/rest_legacy_credentials.tchecksBugzilla_login/Bugzilla_passwordonGET /rest/component-watching, still served by the legacy server, instead of/rest/version.qa/t/rest_bugzilla.t:GET /rest/jobqueue_status?api_key=<key>returns 200.general.md: the resources still on the legacy auth path are now only some extension endpoints.Test plan
GET /rest/version,/rest/timezoneanonymously: 200, same JSON as beforeGET /rest/extensions,/rest/time,/rest/jobqueue_statusanonymously: 401login_required; withX-Bugzilla-API-Key: 200GET /rest/jobqueue_status?api_key=<key>: 200GET /rest/component-watchingwithBugzilla_login/Bugzilla_password: 200, and an error with bad credentialsReferences