Skip to content

Use web-feature keyword instead of [platform-feature] whiteboard entry#517

Merged
jgraham merged 2 commits intomainfrom
web_feature
May 5, 2026
Merged

Use web-feature keyword instead of [platform-feature] whiteboard entry#517
jgraham merged 2 commits intomainfrom
web_feature

Conversation

@jgraham
Copy link
Copy Markdown
Member

@jgraham jgraham commented May 1, 2026

For now allow both; the long term goal is to prefer the web-feature keyword.

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)

  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs

  • Ensure the container image will be using permissions granted to telemetry-airflow responsibly.

For now allow both; the long term goal is to prefer the web-feature keyword.
@jgraham jgraham requested a review from a team as a code owner May 1, 2026 16:35
@jgraham jgraham requested a review from ksy36 May 5, 2026 10:51
`{{ ref('bugzilla_bugs') }}` AS bugs
WHERE CONTAINS_SUBSTR(bugs.whiteboard, "[platform-feature]")
WHERE (CONTAINS_SUBSTR(bugs.whiteboard, "[platform-feature]") OR "web-feature" IN UNNEST(bugs.keywords)
),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing closing parenthesis ) ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

`{{ ref('bugzilla_bugs') }}` AS bugs
WHERE CONTAINS_SUBSTR(bugs.whiteboard, "[platform-feature]")
WHERE (CONTAINS_SUBSTR(bugs.whiteboard, "[platform-feature]") OR "web-feature" IN UNNEST(bugs.keywords)
),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Co-authored-by: jgraham <james@hoppipolla.co.uk>
@jgraham jgraham merged commit 661a1fa into main May 5, 2026
3 checks passed
@jgraham jgraham deleted the web_feature branch May 5, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants