Bug 2027006,2036743: Fetch remote policies on Felt UI before launching Firefox by victhorlopez · Pull Request #790 · mozilla/enterprise-firefox

victhorlopez · 2026-04-24T14:29:33Z

Description

Bugzilla: Bug-2027006

Moves remote policy fetching from Firefox startup to the Felt UI login flow, so policies are available before Firefox launches, and we can avoid extra startups in case of failures
Fetches user info and remote policies in parallel after SSO authentication completes
Passes policies to Firefox via a new IPC message
If either fetch fails, signs the user out, clears SSO cookies, signouts the user, and resets the Felt UI to the login page with a connection error

Dependencies / Related Issues

Depends on:

Screenshots

Testing

Added tests
Manual testing performed

I put a throw with a counter (to make it fail only the first time), and see how the sso works but fails on fetch

victhorlopez · 2026-04-29T11:19:17Z

+            [userInfo, remotePolicies] = await Promise.all([
+              lazy.ConsoleClient.getLoggedInUserInfo(),
+              lazy.ConsoleClient.getRemotePolicies(),
+            ]);


should we add here a check for
remotePolicies == "" or == "{}"

and count it as invalid (i.e throw), otherwise we will open firefox and throw there

What is the justification for the try block?

those are network requests, if they throw an exception you end up with a "blank page" in the sso

victhorlopez · 2026-04-29T11:20:54Z

+            ]);
+          } catch (e) {
+            lazy.log.error(`Failed to fetch startup data: ${e}`);
+            await lazy.ConsoleClient.postSignout().catch(err =>


in theory in this step, we actually managed to log in but either getRemotePolicies or getLoggedInUserInfo failed. I assumed we want to clean up everything?

I defer to @1rneh for that

victhorlopez · 2026-04-29T11:29:43Z


 pub static TOKENS: LazyLock<Arc<RwLock<Tokens>>> =
    LazyLock::new(|| Arc::new(RwLock::new(Default::default())));
+pub static POLICIES: OnceLock<Arc<String>> = OnceLock::new();


I assumed we write only once?

Copilot

Pull request overview

Moves remote enterprise policy retrieval for Felt from Firefox startup into the Felt UI login flow so policies are available before launching Firefox, and failures can be handled without extra Firefox startups.

Changes:

Fetch logged-in user info and remote policies in parallel after SSO completes, and handle failures by signing out/clearing cookies and returning to login with a connection error.
Introduce a new Felt IPC/XPCOM API to pass remote policies to Firefox at startup.
Update enterprise policy startup fetching logic and add/adjust Felt enterprise tests for the new failure/retry behavior.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
toolkit/components/enterprisepolicies/EnterprisePoliciesParent.sys.mjs	Switch Felt startup remote-policy source to `Services.felt.getStartupPolicies()` and remove Felt-specific shutdown logic.
browser/extensions/felt/content/FeltProcessParent.sys.mjs	Fetch user info + policies in parallel; send policies to Firefox via new IPC; add cookie cleanup helper and error-to-login path.
browser/extensions/felt/api.js	Add `FeltParent:ShowLogin` message handler to reset the Felt UI to the login view with an error.
browser/extensions/felt/content/window.js	Listen for `reset-to-login` to reset the UI to login (with optional error type).
browser/components/enterprise/modules/ConsoleClient.sys.mjs	Add `postSignout()` helper for the new failure path.
browser/extensions/felt/rust/nsIFelt.idl	Add `sendPolicies()` / `getStartupPolicies()` XPCOM methods for passing startup policies.
browser/extensions/felt/rust/src/message.rs	Add `Policies(String)` IPC message and bump IPC version.
browser/extensions/felt/rust/src/components.rs	Implement the new XPCOM methods to send/store startup policy payload.
browser/extensions/felt/rust/src/client.rs	Receive/store the policies payload from IPC on the Firefox side.
browser/extensions/felt/rust/src/utils.rs	Add global storage for startup policies.
testing/enterprise/test_felt_browser_init_failures.py	Extend the failure test to assert error UI and successful login after failure.
testing/enterprise/felt_tests.py	Make the SSO test server simulate “existing session cookie skips login form” behavior.

Comments suppressed due to low confidence (1)

toolkit/components/enterprisepolicies/EnterprisePoliciesParent.sys.mjs:1073

fetchPoliciesOnStartup() no longer fetches remote policies for non-Felt runs: res remains undefined when Services.felt?.isFeltBrowser() is false, which makes the subsequent !res?.policies branch always set _failed = true and prevents policies from loading until/if polling later succeeds. This looks like an unintended regression; consider keeping the previous lazy.ConsoleClient.getRemotePolicies() call for the non-Felt path (and optionally falling back to it if getStartupPolicies() throws/returns invalid JSON in the Felt path).

    let res;
    try {
      if (Services.felt?.isFeltBrowser()) {
        res = JSON.parse(Services.felt.getStartupPolicies());
      }
    } catch (e) {
      console.error(`Failed to fetch remote policies on startup: ${e}`);
      this._failed = true;
      return;
    }
    if (!res?.policies) {
      console.error(
        `No policies were found in the response: ${JSON.stringify(res)}.`
      );
      this._failed = true;
    } else {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lissyx · 2026-05-05T12:46:43Z

    resetFeltFirefoxWindowReady();
    gFeltFirefoxReadyNotified = false;

+    this.lastRemotePolicies = remotePolicies;


Since we persist here, do we want to persist also on disk? Would it make any sense? @1rneh what is your opinion?

just to add context on why I am saving this.. it is because if firefox crashes, we need to restart it instantly ( and it uses another path), but.... now I have another question, is this well behaved if the policies changed during runtime? Maybe 1rneh had another idea, to populate also the policies storage from the browser and populate the storage, cause otherwise we might start with old policies?

lissyx · 2026-05-05T12:49:46Z

+            // Clear SSO cookies so the provider does not auto-authenticate
+            // on the next login attempt.
+            this.removeAllCookies();


I think we should do that earlier.

Can you elaborate what would be optimal?

As of now here the cookies are deleted after trying to signout, we did successfully SSO but something failed in whoami/policies

technically since it's private browsing, even quickly after the <browser> is dismissed it's already gone, so I think reloading the window would already be enough

Let me know what would you do in here, (also to have an optimal user experience), cause I tried some things and did not manage to make it work properly until I cleared the cookies (i.e I had problems if I was trying to login a second time)

lissyx · 2026-05-05T12:50:17Z

+            // on the next login attempt.
+            this.removeAllCookies();
+            Services.cpmm.sendAsyncMessage("FeltParent:ShowLogin", {
+              reason: "felt-browser-error-connection",


Likely we want a more focused error message, but this is UX we should discuss with Matthew ?

This is related to your question about what we type of exceptions we can get.. 401 should be handled already(would be weird to get it in this step but you never know), so I would expect here to get a no connection error/ server errors etc (or no policies setup on the console).

Also I'm wondering if we should not handle that just like others in https://searchfox.org/enterprise-main/rev/753b9cbaa2529ceb14c22f0ec69fd5f81294e7a4/browser/extensions/felt/api.js#296-300

I did some changes based on your comment, I hope I went in the right direction.

Regarding like the others, the other they "reset the window", in this case the form is always visible, so we should not call show window cause it opens another window.

I think the actor solution is better

lissyx · 2026-05-05T12:50:41Z

+            break;
+          }
+
+          this.loggedInUserInfo = userInfo;


Why do we add this now?

Because this changed in here

- this.loggedInUserInfo = - await lazy.ConsoleClient.getLoggedInUserInfo(); + let userInfo, remotePolicies; + try { + // TODO: Bug 2003001 - Pass user info from Felt to Firefox to avoid network request on startup + [userInfo, remotePolicies] = await Promise.all([ + lazy.ConsoleClient.getLoggedInUserInfo(), + lazy.ConsoleClient.getRemotePolicies(), + ]);

lissyx · 2026-05-05T13:00:23Z

+      if (Services.felt?.isFeltBrowser()) {
+        res = JSON.parse(Services.felt.getStartupPolicies());
+      }


WOo, that is rather intrusive, I dont know how it collides with the work @1rneh is doing on policies

victhorlopez · 2026-05-06T07:55:00Z

@github-copilot review

victhorlopez self-assigned this Apr 24, 2026

victhorlopez force-pushed the bug/2027006 branch 5 times, most recently from 3618d0f to 320b7b4 Compare April 29, 2026 10:29

victhorlopez commented Apr 29, 2026

View reviewed changes

victhorlopez requested review from 1rneh and lissyx April 29, 2026 11:53

victhorlopez marked this pull request as ready for review April 29, 2026 11:54

gcp requested a review from Copilot April 29, 2026 14:50

Copilot started reviewing on behalf of gcp April 29, 2026 14:52 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread browser/extensions/felt/content/FeltProcessParent.sys.mjs Outdated

Comment thread browser/extensions/felt/rust/src/client.rs

victhorlopez force-pushed the bug/2027006 branch from 320b7b4 to 66c806b Compare April 29, 2026 16:12

victhorlopez mentioned this pull request May 5, 2026

Bug 2036743: Add FELT and thread-manager to background task XPCOM allowlist #833

Closed

2 tasks

victhorlopez added enhancement New feature or request branch:main PR that should be merged on enterprise-main branch labels May 5, 2026

lissyx reviewed May 5, 2026

View reviewed changes

Comment thread browser/components/enterprise/modules/ConsoleClient.sys.mjs Outdated

lissyx reviewed May 5, 2026

View reviewed changes

Comment thread browser/extensions/felt/content/FeltProcessParent.sys.mjs Outdated

lissyx reviewed May 5, 2026

View reviewed changes

victhorlopez marked this pull request as draft May 5, 2026 14:41

victhorlopez removed the request for review from 1rneh May 5, 2026 14:41

victhorlopez force-pushed the bug/2027006 branch 3 times, most recently from cee2307 to 609ac61 Compare May 5, 2026 17:11

victhorlopez force-pushed the bug/2027006 branch 2 times, most recently from 520f691 to 69d04c3 Compare May 5, 2026 18:06

Bug 2027006: Fetch remote policies on Felt UI before launching Firefox

f66cbad

victhorlopez force-pushed the bug/2027006 branch from 69d04c3 to f66cbad Compare May 6, 2026 09:19

victhorlopez changed the title ~~Bug 2027006: Fetch remote policies on Felt UI before launching Firefox~~ Bug 2027006,2036743: Fetch remote policies on Felt UI before launching Firefox May 6, 2026

victhorlopez marked this pull request as ready for review May 6, 2026 11:38

victhorlopez requested a review from 1rneh May 6, 2026 11:39

Conversation

victhorlopez commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies / Related Issues

Screenshots

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victhorlopez May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victhorlopez Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victhorlopez May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victhorlopez May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victhorlopez commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

victhorlopez commented Apr 24, 2026 •

edited

Loading

victhorlopez May 5, 2026 •

edited

Loading

victhorlopez Apr 29, 2026 •

edited

Loading

victhorlopez May 5, 2026 •

edited

Loading

victhorlopez May 5, 2026 •

edited

Loading