Conversation
fd0ea15 to
1326de1
Compare
This pull request
Removes the following routes/handlers:
/v1/oauth/subscriptions/active/new
/v1/oauth/subscriptions/active/new-paypal
/v1/oauth/subscriptions/customer
/v1/oauth/subscriptions/coupon
/v1/oauth/subscriptions/coupon/apply
/v1/oauth/subscriptions/reactivate
/v1/oauth/subscriptions/setupintent/create
/v1/oauth/subscriptions/paymentmethod/default
/v1/oauth/subscriptions/paymentmethod/failed/detach
/v1/oauth/subscriptions/paymentmethod/billing-agreement
/v1/oauth/subscriptions/paypal-checkout
/v1/oauth/subscriptions/invoice/retry
/v1/oauth/subscriptions/invoice/preview
/v1/oauth/subscriptions/invoice/preview-subsequent
/v1/oauth/subscriptions/productname
/v1/oauth/subscriptions/active/{subscriptionId}
/v1/oauth/mozilla-subscriptions/customer/plan-eligibility/{planId}
Closes
PAY-3617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Removes the following routes/handlers:
Removes dead code:
Payment layer methods (lib/payments/stripe.ts):
Route handler methods (lib/routes/subscriptions/stripe.ts):
filterCustomer, filterInvoice, filterIntent, filterSubscription, DeepPartial, couponDTO, invoiceDTO,
SeverityLevel, Sentry, COUNTRIES_LONG_NAME_TO_SHORT_NAME_MAP, addressLookupCountries, buildTaxAddress,
deleteAccountIfUnverified, generateIdempotencyKey, METRICS_CONTEXT_SCHEMA, reportSentryMessage,
reportSentryError, CustomerError, stripeInvoiceToFirstInvoicePreviewDTO,
stripeInvoicesToSubsequentInvoicePreviewsDTO, getAccountCustomerByUid, SubscriptionUpdateEligibility)
PayPal handler (lib/routes/subscriptions/paypal.ts):
_createPaypalBillingAgreementAndSubscription, _createPaypalSubscription, processInvoiceInBackground,
createAndVerifyBillingAgreement, paypalRoutes export
createPayPalBA, error, reportSentryError, msToSec, deleteAccountIfUnverified, SubscriptionEligibilityResult,
buildTaxAddress, DESCRIPTIONS, validators, Stripe, isA, ServerRoute)
PayPal helper (lib/payments/paypal/helper.ts):
Entire files deleted:
clientIdFromMetadataKey, capabilitiesFromMetadataValue, clientIdCapabilityMapFromMetadata)
Stripe formatter (lib/payments/stripe-formatter.ts):
Shared DTO (fxa-shared/dto/auth/payments/invoice.ts):
Validators (lib/routes/validators.js):
subscriptionsInvoicePIExpandedValidator
subscriptionsStripeSubscriptionValidator
Route utils (lib/routes/subscriptions/utils.ts):
Test clients:
From external packages:
Test spec dead imports (various):
getAccountCustomerByUidStub, deleteAccountIfUnverifiedStub, stripeInvoiceToFirstInvoicePreviewDTO,
stripeInvoicesToSubsequentInvoicePreviewsDTO, filterCustomer, filterSubscription, filterInvoice,
filterIntent, openInvoice, invoicePreviewTax, paymentMethodFixture, newSetupIntent, accountUtils
subscriptionPMIExpandedIncompleteCVCFail, newSetupIntent, invoiceRetry, paymentMethodAttach
Issue that this pull request solves
Closes: PAY-3617
Checklist
Put an
xin the boxes that apply