Skip to content

fix(functional-tests): fix failing stage tests #20539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbudhram merged 1 commit into from
May 8, 2026
+4 −22
Merged

fix(functional-tests): fix failing stage tests #20539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 4 additions & 22 deletions packages/functional-tests/tests/pairing/pairChoice.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,37 +22,19 @@ test.describe('severity-2 #smoke', () => {
await settings.checkWebChannelMessage(FirefoxCommand.OAuthFlowBegin);
});

test('Continue on the choice screen dispatches pair_preferences', async ({
test('Continue advances to the download view when no mobile is selected', async ({
target,
syncOAuthBrowserPages: { page },
}) => {
await page.goto(`${target.contentServerUrl}/pair`);
// Click the label so React's onChange fires; the radio is hidden behind
// it, and check() on the input itself fails actionability.
await page.locator('label[for="has-mobile"]').click();
await page.locator('label[for="needs-mobile"]').click();
await expect(page.getByTestId('pair-continue-btn')).toBeEnabled();

// Capture WebChannelMessageToChrome dispatches in a page-side promise
// *before* clicking, so we observe pair_preferences even if Firefox's
// chrome handler tears the test tab down right after.
const dispatched = page.evaluate(
() =>
new Promise<string>((resolve) => {
window.addEventListener(
'WebChannelMessageToChrome',
(e: Event) => {
const detail = JSON.parse((e as CustomEvent).detail);
if (detail.message.command === 'fxaccounts:pair_preferences') {
resolve(detail.message.command);
}
},
{ once: false }
);
})
);

await page.getByTestId('pair-continue-btn').click();
expect(await dispatched).toBe('fxaccounts:pair_preferences');

await expect(page.locator('#pair-header-mobile')).toBeVisible();
});

test('direct /connect_another_device dispatches fxa_status and oauth_flow_begin', async ({
Expand Down