Skip to content

fix(admin): register /waf-tokens with SPA fallback handler#20540

Merged
toufali merged 1 commit intomainfrom
fix-admin-waf-token-reload
May 8, 2026
Merged

fix(admin): register /waf-tokens with SPA fallback handler#20540
toufali merged 1 commit intomainfrom
fix-admin-waf-token-reload

Conversation

@toufali
Copy link
Copy Markdown
Member

@toufali toufali commented May 7, 2026

Because

  • Hard reloading or directly visiting /waf-tokens returned 404 Cannot GET /waf-tokens because the path was missing from the SPA route allowlist in packages/fxa-admin-panel/server/lib/server.ts.

This pull request

  • Adds /waf-tokens to the route array so the server falls through to index.html for that path.

Issue that this pull request solves

Closes: FXA-13701

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • To repro the original bug: check out main, run the admin panel, navigate to /waf-tokens via the nav (works), then hard reload — you'll see the 404.

@toufali toufali requested a review from a team as a code owner May 7, 2026 22:02
Copilot AI review requested due to automatic review settings May 7, 2026 22:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Registers the /waf-tokens admin-panel SPA route with the server-side fallback handler so direct navigation or hard reload serves index.html instead of returning a 404.

Changes:

  • Add /waf-tokens to the SPA route allowlist used by the Express server’s index.html fallback.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@toufali toufali merged commit d28c56d into main May 8, 2026
24 checks passed
@toufali toufali deleted the fix-admin-waf-token-reload branch May 8, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants