Skip to content

Extract viewer preview checks and preparation into scripts - #22095

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:viewer-preview-review
Oct 6, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:viewer-preview-review

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Run preview scripts directly, use timestamps for the deployment timeout, and remove .nojekyll creation and the jq availability check.

@calixteman calixteman added the infra Infrastructure related label Oct 6, 2026
Run preview scripts directly, use timestamps for the deployment timeout,
and remove .nojekyll creation and the jq availability check. Allow the
preview scripts to keep their executable bit in lint-chmod.
@calixteman
calixteman force-pushed the viewer-preview-review branch from c9345f6 to 55a90eb Compare October 6, 2026 19:23
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (5b608a3) to head (55a90eb).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22095      +/-   ##
==========================================
- Coverage   89.58%   89.55%   -0.04%     
==========================================
  Files         270      270              
  Lines       67611    67619       +8     
==========================================
- Hits        60570    60553      -17     
- Misses       7041     7066      +25     
Flag Coverage Δ
browsertest 65.09% <ø> (-0.02%) ⬇️
fonttest 8.95% <ø> (ø)
integrationtest 68.39% <ø> (-0.04%) ⬇️
unittest 59.21% <ø> (-0.01%) ⬇️
unittestcli 58.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good to me, and the workflow steps are quite a bit easier to oversee now; thank you!

(for future reference/context, this PR addresses the review comments from #22090 and #22093)

@timvandermeij
timvandermeij merged commit d9412ac into mozilla:master Oct 6, 2026
22 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infrastructure related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants