Repository navigation
Test main-thread and worker rendering paths - #22096
Open
calixteman wants to merge 1 commit into
Open
calixteman wants to merge 1 commit into
calixteman wants to merge 1 commit into
Conversation
Add main-thread variants for transfer functions, soft masks, knockout groups, and partial rendering via a disableWorkerRendering manifest option. Run the transfer-function unit test with worker rendering enabled and disabled. Use canvas for the optimized partial-render pass so it can run in the renderer worker, matching the full-render pass.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22096 +/- ##
==========================================
- Coverage 90.03% 89.46% -0.57%
==========================================
Files 271 271
Lines 67770 67770
==========================================
- Hits 61015 60629 -386
- Misses 6755 7141 +386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Reference testsResults for e06a8ba (run, references from mozilla/pdf.js.refs@05be816b55).
The report is kept for 30 days and replaced by the next run. |
timvandermeij
approved these changes
Oct 8, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
r=me, with passing browser tests. Thank you for extending the coverage of this logic!
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add main-thread variants for transfer functions, soft masks, knockout groups, and partial rendering via a disableWorkerRendering manifest option. Run the transfer-function unit test with worker rendering enabled and disabled.
Use canvas for the optimized partial-render pass so it can run in the renderer worker, matching the full-render pass.