Repository navigation
Ensure that the RendererWorker version matches the API version, and reduce the size of the *built* pdf.renderer.mjs file (PR 21860 follow-up) - #22097
Merged
Conversation
…21860 follow-up) While the actual implementation differs slightly from the "normal" worker, since the new `RendererWorker` only supports one document, the basic principle is the same. By ensuring that the API *and* worker versions match, we prevent any possible issues that could occur e.g. as a result of caching, which should help prevent strange and hard to debug errors in third-party PDF.js deployments.
…iles (PR 21860 follow-up) This avoids bundling dead code in the *built* `pdf.mjs` and `pdf.renderer.mjs` files. *Note:* This reduces the size of the `gulp mozcentral` bundle by `487` bytes, which isn't a lot but still cannot hurt.
…s (PR 21860 follow-up) This avoids bundling dead code in the *built* `pdf.mjs` and `pdf.renderer.mjs` files. *Note:* This reduces the size of the `gulp mozcentral` bundle by `11898` bytes, i.e. over 11 kilo-bytes, which is way too much to ignore.
Contributor
Reference testsResults for 7765947 (run, references from mozilla/pdf.js.refs@a0031ac7e2).
The report is kept for 30 days and replaced by the next run. Problems on LinuxProblems on Windows |
pdf.renderer.mjs file (PR 21860 follow-up)RendererWorker version matches the API version, and reduce the size of the *built* pdf.renderer.mjs file (PR 21860 follow-up)
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 6, 2026
Contributor
Viewer preview🗑️ Viewer previews removed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22097 +/- ##
==========================================
+ Coverage 90.20% 90.22% +0.01%
==========================================
Files 271 274 +3
Lines 67790 67795 +5
==========================================
+ Hits 61151 61167 +16
+ Misses 6639 6628 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 6, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the
RendererWorkerversion matches the API version (PR 21860 follow-up)While the actual implementation differs slightly from the "normal" worker, since the new
RendererWorkeronly supports one document, the basic principle is the same.By ensuring that the API and worker versions match, we prevent any possible issues that could occur e.g. as a result of caching, which should help prevent strange and hard to debug errors in third-party PDF.js deployments.
Split
DOMCanvasFactoryandOffscreenCanvasFactoryinto separate files (PR 21860 follow-up)This avoids bundling dead code in the built
pdf.mjsandpdf.renderer.mjsfiles.Note: This reduces the size of the
gulp mozcentralbundle by487bytes, which isn't a lot but still cannot hurt.Split
DOMFilterFactoryandWorkerFilterFactoryinto separate files (PR 21860 follow-up)This avoids bundling dead code in the built
pdf.mjsandpdf.renderer.mjsfiles.Note: This reduces the size of the
gulp mozcentralbundle by11898bytes, i.e. over 11 kilo-bytes, which is way too much to ignore.