Repository navigation
Fix the DOMCanvasFactory import in the new debugger (PR 22097 follow-up) - #22098
Merged
calixteman merged 1 commit intoOct 7, 2026
Merged
calixteman merged 1 commit into
calixteman merged 1 commit into
Conversation
…w-up) Given the format of this particular import it unfortunately wasn't caught by linting.
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 6, 2026
Contributor
Viewer preview🗑️ Viewer previews removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22098 +/- ##
==========================================
- Coverage 90.22% 90.21% -0.02%
==========================================
Files 275 275
Lines 67837 67837
==========================================
- Hits 61207 61198 -9
- Misses 6630 6639 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
calixteman
added a commit
that referenced
this pull request
Oct 7, 2026
Resolve `pdfjs/` and `pdfjs-lib` to check for missing modules and exports, including the invalid `DOMCanvasFactory` import fixed in PR #22098. Anchor ignore patterns so relative imports such as `./display_utils.js` are checked by `import/no-unresolved`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the format of this particular import it unfortunately wasn't caught by linting.