Repository navigation
Move the renderRichText function into a new utility file (PR 21860 follow-up) - #22100
Closed
Snuffleupagus wants to merge 1 commit into
Closed
Snuffleupagus wants to merge 1 commit into
Snuffleupagus wants to merge 1 commit into
Conversation
…follow-up) The `renderRichText` function depends on the `XfaLayer` class, and given where that function currently lives it causes all of the `XfaLayer` code to be bundled into the *built* `pdf.renderer.mjs` file. That's unfortunate since all of it is dead code in the renderer-worker, however we can avoid it by simply moving `renderRichText` into its own file. *Note:* This reduces the size of the `gulp mozcentral` bundle by `10088` bytes, i.e. almost 10 kilo-bytes, which is way too much to ignore.
Snuffleupagus
added
core
release-blocker
Contributor
Reference testsResults for 6d0b230 (run, references from mozilla/pdf.js.refs@026380f231).
The report is kept for 30 days and replaced by the next run. Problems on LinuxProblems on Windows |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22100 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 275 276 +1
Lines 67837 67837
=======================================
Hits 61203 61203
Misses 6634 6634
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Viewer preview🗑️ Viewer previews removed. |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Snuffleupagus
marked this pull request as draft
October 7, 2026 10:34
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Collaborator
Author
|
Closing this once, since there's more code that we could skip. |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
renderRichTextfunction depends on theXfaLayerclass, and given where that function currently lives it causes all of theXfaLayercode to be bundled into the builtpdf.renderer.mjsfile.That's unfortunate since all of it is dead code in the renderer-worker, however we can avoid it by simply moving
renderRichTextinto its own file.Note: This reduces the size of the
gulp mozcentralbundle by10088bytes, i.e. almost 10 kilo-bytes, which is way too much to ignore.