Repository navigation
Split the src/display/display_utils.js file into multiple ones (PR 21860 follow-up) - #22101
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22101 +/- ##
==========================================
- Coverage 90.22% 90.21% -0.01%
==========================================
Files 276 277 +1
Lines 67811 67811
==========================================
- Hits 61182 61178 -4
- Misses 6629 6633 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Contributor
Viewer preview🗑️ Viewer previews removed. |
Contributor
Reference testsResults for a4411d2 (run, references from mozilla/pdf.js.refs@05be816b55).
The report is kept for 30 days and replaced by the next run. Problems on LinuxProblems on Windows |
Snuffleupagus
force-pushed
the
dom_utils
branch
from
October 7, 2026 12:16
373a903 to
b9890cf
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Snuffleupagus
force-pushed
the
dom_utils
branch
from
October 8, 2026 19:40
b9890cf to
26d59ca
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
…21860 follow-up) The *built* `pdf.renderer.mjs` file currently contains *a lot* of dead code, since it pulls in the entire `src/display/display_utils.js` file as-is and that one contains many functions that only make sense in the main-thread. Hence we make the following changes: - Move a couple of helpers into the existing `src/display/api_utils.js` file. - Move all functions that access the DOM, or ones that are only invoked in the main-thread, into a new `src/display/dom_utils.js` file. - Keep functions that make sense in both the main- and worker-threads in the existing `src/display/display_utils.js` file. *Note:* This reduces the size of the `gulp mozcentral` bundle by `20787` bytes, i.e. over 20 kilo-bytes, which is way too much to ignore.
Snuffleupagus
force-pushed
the
dom_utils
branch
from
October 8, 2026 19:54
26d59ca to
a4411d2
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built
pdf.renderer.mjsfile currently contains a lot of dead code, since it pulls in the entiresrc/display/display_utils.jsfile as-is and that one contains many functions that only make sense in the main-thread.Hence we make the following changes:
src/display/api_utils.jsfile.src/display/dom_utils.jsfile.src/display/display_utils.jsfile.Note: This reduces the size of the
gulp mozcentralbundle by20787bytes, i.e. over 20 kilo-bytes, which is way too much to ignore.