Repository navigation
Conversation
Its two consumers switched to `ancestors` in 11573dd (XFA - Implement usehref support), so the set has been built and never read since.
Contributor
Viewer previewCommit c745c6f (build logs).
🔒 A user with write access must approve this commit with the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22102 +/- ##
==========================================
- Coverage 90.22% 90.19% -0.03%
==========================================
Files 275 275
Lines 67837 67835 -2
==========================================
- Hits 61203 61187 -16
- Misses 6634 6648 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_applyPrototypecopiesancestorsinto anewAncestorsset and addsprototo it, but nothing reads the set. Its two consumers, the recursive$resolvePrototypescalls, were changed to passancestorsin 11573dd ("XFA - Implement usehref support"), and the declaration was left behind.Cycle detection is unaffected: it still goes through
ancestorsin_getPrototypeand at the top of_applyPrototype.https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq