Repository navigation
A couple of RendererWorker improvements (PR 21860 follow-up) - #22103
Merged
Merged
Conversation
This patch contains a couple of different, but small, improvements: - Add a placeholder entry for `rendererWorker`, in the `transportParams` used in `getDocument`, to avoid having to needlessly copy the object. - Remove pointless fallback values in the `WorkerTransport` constructor, since those parameters should always be available. - Give the `pdfBug` parameter the *correct* default value in the `ObjectHandler` constructor. - Always set `inspectFont = null` in the renderer-worker, since the `FontInspector` will never exist there.
Contributor
Reference testsResults for 35546c2 (run, references from mozilla/pdf.js.refs@026380f231).
The report is kept for 30 days and replaced by the next run. Problems on LinuxProblems on Windows |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Contributor
Viewer preview🗑️ Viewer previews removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22103 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 275 275
Lines 67837 67838 +1
=======================================
+ Hits 61203 61206 +3
+ Misses 6634 6632 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch contains a couple of different, but small, improvements:
Add a placeholder entry for
rendererWorker, in thetransportParamsused ingetDocument, to avoid having to needlessly copy the object.Remove pointless fallback values in the
WorkerTransportconstructor, since those parameters should always be available.Give the
pdfBugparameter the correct default value in theObjectHandlerconstructor.Always set
inspectFont = nullin the renderer-worker, since theFontInspectorwill never exist there.