Skip to content

A couple of RendererWorker improvements (PR 21860 follow-up) - #22103

Merged
calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:RendererWorker-fixes-2
Oct 7, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:RendererWorker-fixes-2

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This patch contains a couple of different, but small, improvements:

  • Add a placeholder entry for rendererWorker, in the transportParams used in getDocument, to avoid having to needlessly copy the object.

  • Remove pointless fallback values in the WorkerTransport constructor, since those parameters should always be available.

  • Give the pdfBug parameter the correct default value in the ObjectHandler constructor.

  • Always set inspectFont = null in the renderer-worker, since the FontInspector will never exist there.

This patch contains a couple of different, but small, improvements:
 - Add a placeholder entry for `rendererWorker`, in the `transportParams` used in `getDocument`, to avoid having to needlessly copy the object.

 - Remove pointless fallback values in the `WorkerTransport` constructor, since those parameters should always be available.

 - Give the `pdfBug` parameter the *correct* default value in the `ObjectHandler` constructor.

 - Always set `inspectFont = null` in the renderer-worker, since the `FontInspector` will never exist there.
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 35546c2 (run, references from mozilla/pdf.js.refs@026380f231).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1382 11m 29s 0 1 0 0 view differences
Windows ⚠️ 1382 15m 22s 0 1 0 0 view differences

The report is kept for 30 days and replaced by the next run.

Problems on Linux
TEST-UNEXPECTED-FAIL | test failed issue16114-partial | in firefox-1 | page1 round 1 | Optimized rendering differs from full rendering.
Problems on Windows
TEST-UNEXPECTED-FAIL | test failed issue16114-partial | in firefox-1 | page1 round 1 | Optimized rendering differs from full rendering.
TEST-UNEXPECTED-FAIL | test failed tracemonkey-partial-2 | in firefox-0 | page2 round 1 | Optimized rendering differs from full rendering.
TEST-UNEXPECTED-FAIL | test failed tracemonkey-partial-2 | in firefox-0 | page4 round 1 | Optimized rendering differs from full rendering.
TEST-UNEXPECTED-FAIL | test failed tracemonkey-partial-2 | in firefox-0 | page6 round 1 | Optimized rendering differs from full rendering.
TEST-UNEXPECTED-FAIL | test failed tracemonkey-partial-2 | in firefox-0 | page7 round 1 | Optimized rendering differs from full rendering.
TEST-UNEXPECTED-FAIL | test failed tracemonkey-partial-2 | in firefox-0 | page8 round 1 | Optimized rendering differs from full rendering.
TEST-UNEXPECTED-FAIL | test failed tracemonkey-partial-2 | in firefox-0 | page10 round 1 | Optimized rendering differs from full rendering.
TEST-UNEXPECTED-FAIL | test failed tracemonkey-partial-2 | in firefox-0 | page13 round 1 | Optimized rendering differs from full rendering.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (24de17e) to head (35546c2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22103   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files         275      275           
  Lines       67837    67838    +1     
=======================================
+ Hits        61203    61206    +3     
+ Misses       6634     6632    -2     
Flag Coverage Δ
browsertest 66.20% <100.00%> (+0.03%) ⬆️
fonttest 8.98% <ø> (ø)
integrationtest 70.01% <100.00%> (+<0.01%) ⬆️
unittest 59.90% <100.00%> (-0.03%) ⬇️
unittestcli 58.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 7, 2026

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman
calixteman merged commit 89b500f into mozilla:master Oct 7, 2026
34 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 7, 2026
@Snuffleupagus
Snuffleupagus deleted the RendererWorker-fixes-2 branch October 7, 2026 16:01

This branch was successfully deployed

1 active deployment
sync_pdfs — 35546c2c Deployed Oct 7, 2026 by Snuffleupagus via request #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core release-blocker Blocker for the upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants