Repository navigation
Reduce duplication in the type1FontGlyphMapping function - #22104
Merged
timvandermeij merged 1 commit intoOct 8, 2026
Merged
timvandermeij merged 1 commit into
timvandermeij merged 1 commit into
Conversation
Currently the same exact code is duplicated three times, which seems completely unnecessary, however that can be avoided with the introduction of a new helper function.
Contributor
Reference testsResults for e3b563d (run, references from mozilla/pdf.js.refs@cfb07bcc7a).
The report is kept for 30 days and replaced by the next run. Problems on LinuxProblems on Windows |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22104 +/- ##
=======================================
Coverage 90.21% 90.22%
=======================================
Files 275 275
Lines 67838 67834 -4
=======================================
+ Hits 61202 61203 +1
+ Misses 6636 6631 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Viewer preview🗑️ Viewer previews removed. |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
timvandermeij
approved these changes
Oct 8, 2026
Collaborator
|
Thank you for deduplicating this! |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the same exact code is duplicated three times, which seems completely unnecessary, however that can be avoided with the introduction of a new helper function.