Repository navigation
Move renderer worker support out of api.js (PR 21860 follow-up) - #22105
Merged
Merged
Conversation
Contributor
Reference testsResults for 5e7bdbf (run, references from mozilla/pdf.js.refs@cfb07bcc7a).
The report is kept for 30 days and replaced by the next run. Problems on LinuxProblems on Windows |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22105 +/- ##
=======================================
Coverage 90.21% 90.22%
=======================================
Files 275 276 +1
Lines 67838 67811 -27
=======================================
- Hits 61202 61181 -21
+ Misses 6636 6630 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Viewer preview🗑️ Viewer previews removed. |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Snuffleupagus
left a comment
Snuffleupagus
left a comment
Collaborator
There was a problem hiding this comment.
Given the size/scope of this patch I don't have time to properly review it today, but hopefully tomorrow.
Contributor
Author
|
FYI, the font issue on windows isn't related to this patch but it's more likely an issue when loading a same font in Firefox. |
calixteman
force-pushed
the
renderer-worker-api-cleanup
branch
from
October 7, 2026 20:36
eda5820 to
9f7bcf3
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 7, 2026
Snuffleupagus
approved these changes
Oct 8, 2026
Snuffleupagus
left a comment
Snuffleupagus
left a comment
Collaborator
There was a problem hiding this comment.
This feels much better structured; thank you!
r=me, with a couple of small suggestions/questions.
Extract RendererWorker and WorkerRenderTask into renderer_worker_proxy.js. Share worker URL wrapping and canvas tracker creation. Forward only page objects stored on the main thread, removing the renderer's cleaned-page tracking and restorePage message. Create the annotation canvases with the canvas factory, as main-thread rendering does, so they're no longer dropped when rendering into an OffscreenCanvas.
calixteman
force-pushed
the
renderer-worker-api-cleanup
branch
from
October 8, 2026 14:28
9f7bcf3 to
5e7bdbf
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract RendererWorker and WorkerRenderTask into renderer_worker_proxy.js. Share worker URL wrapping and canvas tracker creation.
Forward only page objects stored on the main thread, removing the renderer's cleaned-page tracking and restorePage message.