Add elements_check and elements_counter options to compile_crystal method#17
Open
akvatol wants to merge 2 commits intompds-io:masterfrom
Open
Add elements_check and elements_counter options to compile_crystal method#17akvatol wants to merge 2 commits intompds-io:masterfrom
akvatol wants to merge 2 commits intompds-io:masterfrom
Conversation
|
Hello @akvatol! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
blokhin
reviewed
Nov 27, 2024
| import jmespath | ||
|
|
||
| from .errors import APIError | ||
| from .utils import all_divmod_equal |
blokhin
changed the title
Member
|
@akvatol please, let's also revisit this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add elements_check option in compile_crystal method