Repository navigation
[material-ui] Fix theme defaultProps and missing exports - #49332
Merged
Merged
Conversation
- RadioGroup and MenuList now read theme defaultProps - Export usePagination from the root types - Export get*UtilityClass from Stack and TablePaginationActions at runtime - Add MuiTabScrollButton to the theme component types
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
ZeeshanTamboli
approved these changes
Oct 7, 2026
mnajdova
approved these changes
Oct 7, 2026
Member
|
Let's cherry-pick these fixes to v9, what do you think? |
Janpot
added
needs cherry-pick
Contributor
|
Cherry-pick PRs will be created targeting branches: v9.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few places where the theme types or the type declarations promise something the runtime doesn't deliver.
RadioGroupandMenuListare listed in the theme types, but they never calleduseDefaultProps, sotheme.components.MuiRadioGroup.defaultPropsandMuiMenuList.defaultPropshad no effect. They now do.styleOverridesandvariantsstill don't apply, since neither component has its own styled root.usePaginationwas exported from the rootindex.jsbut missing fromindex.d.ts.Stack/index.jsandTablePaginationActions/index.jsdidn't re-export their classes module, sogetStackUtilityClassandgetTablePaginationActionsUtilityClasswere typed butundefinedat runtime.MuiTabScrollButtonworks at runtime (useDefaultPropsandstyleduse that name) but was missing fromcomponents.ts,props.tsandoverrides.ts.Part of #49337