[charts] Refactor FunnelChart classes structure#21652
Merged
JCQuintas merged 13 commits intomui:masterfrom Mar 17, 2026
Merged
Conversation
Introduce a new consolidated `funnelClasses` with `MuiFunnelChart` prefix, following the same pattern as the BarChart refactoring. The deprecated `funnelSectionClasses` with `MuiFunnelSection` prefix remains functional. Components now apply both old and new classes for backward compatibility.
|
Deploy preview: https://deploy-preview-21652--material-ui-x.netlify.app/ Bundle size report
|
Member
|
I noticed the which starts by const themedProps = useThemeProps({
props,
// eslint-disable-next-line mui/material-ui-name-matches-component-name
name,
});So I added them in the types of the theme props override, because it would be sad to pay the cost of a theme props override and do not make it available at the type checking level. |
github-actions
Bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
JCQuintas
added
type: enhancement
…-funnel-chart-classes
github-actions
Bot
removed
the
PR: out-of-date
JCQuintas
requested review from
alexfauquette and
bernardobelchior
as code owners
alexfauquette
approved these changes
Mar 17, 2026
Member
alexfauquette
left a comment
alexfauquette
left a comment
There was a problem hiding this comment.
Looks more like a cleanup than a refactor of the classes
Comment on lines
+33
to
37
| MuiHeatmapPlot: { | ||
| styleOverrides: { | ||
| highlighted: { backgroundColor: 'red' }, | ||
| // @ts-expect-error invalid MuiHeatmap class key | ||
| root: { backgroundColor: 'red' }, | ||
| // @ts-expect-error invalid MuiChartsAxis class key | ||
| constent: { color: 'red' }, |
Member
Author
There was a problem hiding this comment.
I think I just scrambled the merge 😆
Contributor
|
Cherry-pick PRs will be created targeting branches: v8.x |
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Co-authored-by: alex <alex.fauquette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18496
Follows the same pattern as #21601 (BarChart).
funnelClasses.tswithMuiFunnelChartprefixfunnelSectionClasses.ts(MuiFunnelSection) kept fully functional with@deprecatedmarkersMuiFunnelChartentry,MuiFunnelSectiondeprecatedroot,section,sectionFilled,sectionOutlined,sectionLabelTest plan
funnelClasses.*selectors work on DOM elements🤖 Generated with Claude Code