Skip to content

[DataGrid] Make overridesResolver of ResizablePanelHandle dynamic#21724

Merged
sai6855 merged 3 commits intomui:masterfrom
sai6855:resize-classes-refactor
Apr 13, 2026
Merged

[DataGrid] Make overridesResolver of ResizablePanelHandle dynamic#21724
sai6855 merged 3 commits intomui:masterfrom
sai6855:resize-classes-refactor

Conversation

@sai6855
Copy link
Copy Markdown
Member

@sai6855 sai6855 commented Mar 12, 2026

Tiny refactor to reduce bundle size without hurting code readability

Copilot AI review requested due to automatic review settings March 12, 2026 14:26
@sai6855 sai6855 marked this pull request as draft March 12, 2026 14:27
@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 12, 2026

Deploy preview: https://deploy-preview-21724--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium ▼-62B(-0.01%) ▼-2B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 57c047c

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ResizablePanelHandle styling hook-up so theme style overrides for the handle’s orientation are resolved based on the current direction, rather than always including both horizontal and vertical override entries.

Changes:

  • Makes overridesResolver select the resizablePanelHandle--{direction} override dynamically from ownerState.direction.
  • Removes the duplicated horizontal/vertical override blocks in favor of a single computed key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@sai6855 sai6855 added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Mar 12, 2026
@sai6855 sai6855 marked this pull request as ready for review March 12, 2026 14:34
@arminmeh arminmeh changed the title [data-grid] Make overridesResolver of ResizablePanelHandle dynamic [DataGrid] Make overridesResolver of ResizablePanelHandle dynamic Apr 8, 2026
@arminmeh arminmeh added feature: Rendering layout Related to the data grid Rendering engine feature: Column resize and removed feature: Column resize feature: Rendering layout Related to the data grid Rendering engine labels Apr 8, 2026
@sai6855 sai6855 enabled auto-merge (squash) April 8, 2026 06:26
@sai6855 sai6855 merged commit 2454c76 into mui:master Apr 13, 2026
21 checks passed
arminmeh added a commit to arminmeh/mui-x that referenced this pull request Apr 29, 2026
…mui#21724)

Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Column resize performance scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants