Skip to content

Fix sniper bullet sync on maximum bandwidth reduction#4763

Merged
Dutchman101 merged 1 commit intomultitheftauto:masterfrom
ArranTuna:bsynfix4
Apr 4, 2026
Merged

Fix sniper bullet sync on maximum bandwidth reduction#4763
Dutchman101 merged 1 commit intomultitheftauto:masterfrom
ArranTuna:bsynfix4

Conversation

@ArranTuna
Copy link
Copy Markdown
Collaborator

@ArranTuna ArranTuna commented Mar 22, 2026

Summary

If a server has bandwidth reduction set to maximum, long distance shots do not sync, though actually doesn't even need to be that far, if the player is not looking in that direction.

Video of it not working and video of it working with PR: https://cit.gg/arran/vids/bsyncfix2.mp4

This is actually just re-adding what used to exist:

image

This commit removed it: 45d6996#diff-3ca556956f6236bbcafbd7e847f5bda360c3db9fceea0c6b79ee4fb28bbcdb89

Motivation

Players get angry if bullets don't do any damage. Although I can work around it for now by using "medium" instead of "maximum" this will cause a lot of problems for servers using maximum that are unaware of this and have updated their server since bullet sync was refactored.

Test plan

I used 2 PCs, made sure the player being shot is looking away (changes their zone for bandwidth reduction) which causes the bullets to not sync as you can see in the above video. I then tested other guns with the PR and at different bandwidth reductions to make sure everything seemed normal.

Checklist

  • Your code should follow the coding guidelines.
  • Smaller pull requests are easier to review. If your pull request is beefy, your pull request should be reviewable commit-by-commit.

If bandwidth reduction is on maximum and a player doesn't look towards the player shooting a long distance weapon at them, they weren't receiving the bullet sync
@ArranTuna ArranTuna requested a review from a team as a code owner March 22, 2026 11:36
@FileEX
Copy link
Copy Markdown
Member

FileEX commented Mar 22, 2026

Please fix clang format

@ArranTuna
Copy link
Copy Markdown
Collaborator Author

Please fix clang format

Can't, the clang format issues is from master.

@Dutchman101
Copy link
Copy Markdown
Member

Let's first try to ask @Nico8345 if there was a particular reason to remove that line

@Dutchman101 Dutchman101 merged commit 49cbd31 into multitheftauto:master Apr 4, 2026
8 of 9 checks passed
@ArranTuna ArranTuna deleted the bsynfix4 branch April 9, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants