Repository navigation
Take the time the fuel was read with a fix fuel report - #332
Merged
Merged
Conversation
The fix fuel report accepts an optional reportedAt. It must not be in the future and not before the actual takeoff; without it the current time is stored as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpenTofu plan for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /api/v1/flight/:id/route/fix/:ordinal/fuel-reportaccepts an optionalreportedAt(ISO date), the time the pilot read the fuel over the fix. Without it the current time is stored, as before.reportedAtin the future (beyond a one-minute clock allowance) fails validation with400; a time before the actual takeoff answers422(FixFuelReportedBeforeTakeoffError).The web app sends the field from the fuel report modal (mypreflight/app, branch
fuel-report-time).Test plan
features/flight/route.fix-fuel-report.feature: 18 scenarios pass, including the new time, before-takeoff and future/invalid-time cases🤖 Generated with Claude Code