Repository navigation
Add default JSONDecoder to Configuration protocol - #99
Merged
Merged
Conversation
pietbrauer
force-pushed
the
feature/configuration-decoder
branch
from
May 14, 2026 12:25
df1d3e7 to
ffec93e
Compare
Callers (e.g. Octokit.swift) were recreating an identical JSONDecoder on every request. Configuration now exposes a decoder property with a default implementation returning JSONDecoder(), and load()/post() fall back to configuration.decoder when no explicit decoder is passed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pietbrauer
force-pushed
the
feature/configuration-decoder
branch
from
May 14, 2026 13:10
ffec93e to
983a74f
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers (e.g. Octokit.swift) were recreating an identical JSONDecoder on every request. Configuration now exposes a decoder property with a default implementation returning JSONDecoder(), and load()/post() fall back to configuration.decoder when no explicit decoder is passed.