Skip to content

Audio Player: Reset silence detection on track change, set minimum values for length fields #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TakuikaNinja wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Audio Player: Reset silence detection on track change, set minimum values for length fields #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Core/Shared/Audio/AudioPlayerHud.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ void AudioPlayerHud::Draw(uint32_t frameCounter, double fps)
double silenceLength = (double)(frameCounter - _lastAudioFrame) / fps;
if(audioCfg.AudioPlayerAutoDetectSilence && silenceLength >= audioCfg.AudioPlayerSilenceDelay) {
//Silence detected, move to next track
_lastAudioFrame = frameCounter;
_prevFps = fps;
MoveToNextTrack();
}
}
Expand Down
4 changes: 2 additions & 2 deletions UI/Views/AudioConfigView.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,12 @@
<StackPanel Margin="10 5 0 0">
<StackPanel Orientation="Horizontal">
<CheckBox IsChecked="{Binding Config.AudioPlayerAutoDetectSilence}" Content="{l:Translate chkAudioPlayerAutoDetectSilence}" />
<c:MesenNumericUpDown Margin="5 1" Maximum="999999" Value="{Binding Config.AudioPlayerSilenceDelay}" IsEnabled="{Binding Config.AudioPlayerAutoDetectSilence}" />
<c:MesenNumericUpDown Margin="5 1" Minimum="1" Maximum="999999" Value="{Binding Config.AudioPlayerSilenceDelay}" IsEnabled="{Binding Config.AudioPlayerAutoDetectSilence}" />
<TextBlock Text="{l:Translate lblMillisecondsOfSilence}" />
</StackPanel>
<StackPanel Orientation="Horizontal">
<CheckBox IsChecked="{Binding Config.AudioPlayerEnableTrackLength}" Content="{l:Translate chkAudioPlayerEnableTrackLength}" />
<c:MesenNumericUpDown Margin="5 1" Maximum="9999" Value="{Binding Config.AudioPlayerTrackLength}" IsEnabled="{Binding Config.AudioPlayerEnableTrackLength}" />
<c:MesenNumericUpDown Margin="5 1" Minimum="1" Maximum="9999" Value="{Binding Config.AudioPlayerTrackLength}" IsEnabled="{Binding Config.AudioPlayerEnableTrackLength}" />
<TextBlock Text="{l:Translate lblSeconds}" />
</StackPanel>
</StackPanel>
Expand Down
Loading