Repository navigation
FDS: Implement DRAM refresh watchdog - #302
Open
TakuikaNinja wants to merge 5 commits into
Open
TakuikaNinja wants to merge 5 commits into
TakuikaNinja wants to merge 5 commits into
Conversation
- Timing matches FDS-4030D1-Addr test - No regressions in timer IRQ test suite
- Checked against older FDS-4030D1-Micro test
TakuikaNinja
force-pushed
the
FDS-DRAM-Watchdog
branch
from
November 4, 2026 03:16
154b019 to
b8234ee
Compare
Author
|
I found some inaccuracies when comparing against the older FDS-4030D1-Micro test, so I've fixed those and the numbers match my console there as well.
|
Also only call UpdateIRQState when flags have changed
Author
|
I've been checking the commercial library and I haven't noticed any obvious performance dips at max speed with the current changes. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR implements the FDS DRAM refresh watchdog that was discovered last year. (It's been over a year already? Jeez...)
I've tested a random selection of commercial titles and homebrew programs so far (some of which indeed use "everything in NMI" and trigger the IRQ) but it will obviously need more thorough game testing and performance profiling. There's also one edge case labelled as a TODO which I'll need to test on original hardware, though it involves toggling $4023.D7 and thus should be irrelevant for everything else which preserves the $83 value set by the BIOS.