Skip to content

Refresh Overview spend after provider updates - #1061

Merged
Finesssee merged 1 commit into
mainfrom
reauthor/1038-overview-spend-refresh
Nov 2, 2026
Merged

Finesssee merged 1 commit into
mainfrom
reauthor/1038-overview-spend-refresh

Conversation

@Finesssee

Copy link
Copy Markdown
Collaborator

Re-authored from #1038 by @ZGHJP (credited with Co-authored-by). Supersedes #1038.

Summary

  • The Overview spend summary re-reads after provider-updated events (debounced).
  • An older read can no longer overwrite a newer one.
  • The event listener is registered before the first read, and the first read runs once registration settles. An update that lands during registration still triggers a fresh read. This addresses the CodeRabbit finding on Refresh tray overview spend after provider updates #1038.

Commands run (Windows host, apps/desktop-tauri)

  • pnpm exec vitest run --maxWorkers=4 on the affected tests: 52 passed
  • pnpm exec tsc --noEmit -p .: passed

The React act(...) warning in the test output also appears on main; it is not new.

Not run locally: the full Vitest suite; CircleCI runs it. No CUA proof; the change is data refresh timing with no layout change.

Re-authored from #1038. The Overview spend summary re-reads after provider-updated events (debounced), and an older read can no longer overwrite a newer one. The listener is registered before the first read so an update that lands during registration still triggers a fresh read.

Co-authored-by: ZGHJP <43691496+ZGHJP@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1d3c130 and 6da1374.

Files selected for processing: 2
  • apps/desktop-tauri/src/surfaces/TrayPanel.test.tsx
  • apps/desktop-tauri/src/surfaces/TrayPanel.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Finesssee

Copy link
Copy Markdown
Collaborator Author

Self-review for head 6da13745c, because CodeRabbit was rate-limited. The diff is #1038's change applied to current main and the fix for CodeRabbit's finding on #1038: the provider-updated listener is registered before the first spend read, and a generation counter drops stale reads. I read the full diff and found no other issues. CircleCI pr-check passed on this head.

@Finesssee
Finesssee merged commit 5b14c69 into main Nov 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant