Repository navigation
Add pace to serve /usage rows #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Finesssee
wants to merge
3
commits into
main
Choose a base branch
from
fix/1057-serve-usage-pace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: nesszer/Win-CodexBar
Length of output: 8057
Script executed:
Repository: nesszer/Win-CodexBar
Length of output: 39578
Test the configured
/usagepath.The new tests cover
usage_row, but not the/usagepath that readsSettings::weekly_progress_work_days. A regression that substitutes the default value infetch_usage_rowcan pass both tests. Add a route-level or fetch-path test with a non-default configured work-day value and assert the resulting pace.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai Partly addressed in the next commit.
usage_row_pace_follows_weekly_work_daysbuilds a row with a non-defaultSome(5)work-days value and asserts its weekly pace runs ahead of the linear (None) pace. That proves the value passed to the row builder reaches the pace.I skipped a route-level test.
usage_responsereadsSettings::load()from the user's config file and runs a live provider fetch, and neither has a test seam inservetoday. Adding one only for this would be a bigger change than the feature. The remaining wiring is a single pass-through,settings.weekly_progress_work_days, intofetch_usage_row, and the same code fillsapi_regionfrom thatsettingsvalue right next to it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Finesssee That scope decision is reasonable. The supplied code shows
settings.weekly_progress_work_dayspasses throughfetch_usage_rowtousage_rowwithout a default substitution.usage_row_pace_follows_weekly_work_daysadds coverage for the non-default value at the row-builder boundary. It does not test the settings-to-fetch path, so the original coverage gap remains. That gap is not evidence of a wiring defect.I accept leaving the route-level test out of this PR. I am not requesting a test-seam refactor for this change.
Learnings used
You are interacting with an AI system.