You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
SOW-0161: source-timestamp index counts the captured entry population once - #19
Decisions for review (agent-chosen, pending your review)
Membership rule: the source-timestamp histogram uses the same rule the field-bitmap path already used.
Postings past the captured tail are ignored.
A posting the global entry array doesn't contain fails indexing (MissingOffset) on a stable file.
On a live file (online, or active file name) such a posting is dropped.
Live tolerance in the bitmap path: the field-bitmap path now also drops these postings on live files instead of failing.
Reason: the Rust writer links an entry into the DATA arrays before it increments n_entries.
In that window a live reader legitimately sees DATA postings for an entry the global array doesn't count yet.
Repeated source field: an entry with the source field twice keeps its earliest timestamp and counts once.
No CACHE_VERSION bump: cached indexes differ only for corrupt files or files with repeated source fields, and a bump would reindex every cached file.
Go has no equivalent surface: journal-index is Rust-only, and the Go explorer builds no posting-based histogram.
Reproduced before the fix (regular and compact)
Rows published after the captured tail: counted (16 for 14).
Source posting naming a non-ENTRY object: accepted (15 records for 14 entries).
Repeated source value: double-counted (5 for 4).
Link-before-count live window: extra entry counted.
Validation
journal-index/tests/source_postings.rs: 5 new tests. All fail on the old code and pass on the new.
cargo test --workspace: 46 suites pass.
Cost: one comparison per posting and one counter per global entry. The member set is built only on a mismatch.
Summary by cubic
Fixes the source-timestamp histogram so it counts the captured ENTRY population once per entry, sharing the field-bitmap path's membership rule.
Postings past the captured tail and postings naming no entry of the global array are dropped on every file, stable or live, in both the source and requested-field paths; live writers link DATA before counting an entry, and pre-v0.9.0 SDK writers could close a file with the links of a failed append.
An entry with the source field more than once keeps its earliest timestamp and counts once.
CACHE_VERSION bumps to 5, so every cached file reindexes once after upgrade.
Validation: 4 tests in source_postings.rs reproduce the old behavior on live and stable files and pass on the fix; cargo test --workspace passes 46 suites.
Written for commit 0e2f707. Summary will update on new commits.
The file indexer counted source postings published after its captured tail,
counted an entry once per repeated source value, and accepted postings that
name no entry. Stable files with such postings now fail indexing; live files
drop them, because writers link DATA postings before counting the entry.
The field-bitmap path tolerates the same live window.
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: b005f7de-1af7-4023-bcde-978d049f0284
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Files written by SDK releases before v0.9.0 can carry DATA links to an
uncounted entry after a failed append; rejecting them made such archived
files unindexable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Stacked on #18. Merge order: #13 → #14 → #15 → #16 → #17 → #18 → this. Completes SOW-0161 (
.agents/sow/done/SOW-0161-20261017-file-indexer-source-posting-membership.md).Decisions for review (agent-chosen, pending your review)
MissingOffset) on a stable file.n_entries.CACHE_VERSIONbump: cached indexes differ only for corrupt files or files with repeated source fields, and a bump would reindex every cached file.Go has no equivalent surface:
journal-indexis Rust-only, and the Go explorer builds no posting-based histogram.Reproduced before the fix (regular and compact)
Validation
journal-index/tests/source_postings.rs: 5 new tests. All fail on the old code and pass on the new.cargo test --workspace: 46 suites pass.Summary by cubic
Fixes the source-timestamp histogram so it counts the captured ENTRY population once per entry, sharing the field-bitmap path's membership rule.
CACHE_VERSIONbumps to 5, so every cached file reindexes once after upgrade.source_postings.rsreproduce the old behavior on live and stable files and pass on the fix;cargo test --workspacepasses 46 suites.Written for commit 0e2f707. Summary will update on new commits.