Fix doFinally fallback to await onFinally thenables via doAwait

[nev21]

• Refactors the fallback branch of doFinally (for promise-like values without native finally) to reuse doAwait instead of manually checking isPromiseLike and chaining then.
• Preserves ES2018 finally semantics by waiting for the onFinally result before propagating the original fulfillment value or rejection reason.
• Reduces duplicated logic across success and error paths in the simulated finally implementation.
• Adds a narrow type assertion on the value.then(...) assignment to satisfy TypeScript inference for the mixed promise-like return type while keeping behavior unchanged.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.49%. Comparing base (d547a4d) to head (d3a428e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   96.96%   97.49%   +0.53%     
==========================================
  Files          27       27              
  Lines        1450     1438      -12     
  Branches      341      337       -4     
==========================================
- Hits         1406     1402       -4     
+ Misses         44       36       -8     

Files with missing lines	Coverage Δ
lib/src/promise/await.ts	100.00% <100.00%> (+8.16%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR refactors doFinally()’s polyfilled finally behavior (for promise-like values that don’t implement .finally) to reuse the existing doAwait() helper so that finallyFn() results (including thenables) are awaited before propagating the original fulfillment value or rejection reason.

Changes:

• Refactor doFinally()’s fallback implementation to use doAwait(finallyFn(), ...) in both fulfillment and rejection paths.
• Add a type assertion on the fallback .then(...) return to satisfy TypeScript inference.
• Update the Rush npm-shrinkwrap.json with a large removal of Rollup optional/platform package entries (and fsevents).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

File	Description
lib/src/promise/await.ts	Refactors doFinally() fallback logic to reuse doAwait() when .finally is unavailable.
common/config/rush/npm-shrinkwrap.json	Alters the lockfile content, including removal of many Rollup optional binary package entries.

Files not reviewed (1)

• common/config/rush/npm-shrinkwrap.json: Language not supported

Comments suppressed due to low confidence (1)

common/config/rush/npm-shrinkwrap.json:827

• The shrinkwrap removes most of Rollup’s platform-specific optional binary packages from the packages map (only a couple of win32 entries remain here), but node_modules/rollup still declares those optionalDependencies later in the file. This makes the lockfile incomplete and can break deterministic installs (and potentially npm ci) on Linux/macOS/ARM where npm would need entries like node_modules/@rollup/rollup-linux-x64-gnu, ...-darwin-x64, etc. Please regenerate the shrinkwrap (e.g., via node common/scripts/install-run-rush.js update --full on a clean repo) and ensure all Rollup optional binary packages are consistently represented in packages.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• www.googleapis.com
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[nevware21-bot]

Approved by nevware21-bot

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• www.googleapis.com
  • Triggering command: /usr/local/bin/node node install.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[nevware21-bot]

Approved by nevware21-bot