Skip to content

fix(ui): make list rows, page headers and page widths consistent - #211

Merged
skjnldsv merged 2 commits into
mainfrom
fix/list-consistency
Nov 17, 2026
Merged

skjnldsv merged 2 commits into
mainfrom
fix/list-consistency

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Three inconsistencies across the views:

  • Sick leave recorded by HR had no status chip in the lists, while every other row has one.
  • "New request" and "Record absence" were both in the navigation and in the page header.
  • The page title sat 50 px to the right of the content on half the pages.

HR-recorded leave now shows a "Recorded" chip. The header button only shows while the navigation is closed. Every page uses the same left edge. On HR Absences, rows show the available days, the same figure as everywhere else.

Before After

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working AI assisted This PR contains AI-assisted commits labels Nov 17, 2026
@skjnldsv skjnldsv self-assigned this Nov 17, 2026
Sick leave and other HR-recorded rows had no status chip once booked, while
every other row had one. They now show a "Recorded" chip, in the lists and
in the request sidebar; the approval stepper stays hidden for them.

My leave and Absences repeated the navigation's "New request" and "Record
absence" as header buttons. These header buttons now only show while the
app navigation is closed, so each action is offered once.

Centered reading-width pages pushed their title about 50 px right of their
content, to clear the navigation toggle, while full-width pages did not.
The shared page wrapper now keeps the whole page clear of the toggle and
left-aligned: every view has its title on the content's left edge, tables
and timelines use the full width, forms, lists and cards a reading width.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
The Absences rows said "N days left", the remaining figure before pending
requests, while the rest of the app speaks of what is available. The rows
now show "N available" (entitlement minus used minus pending), and the
list item's prop is named for it.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv force-pushed the fix/list-consistency branch from beaf818 to 67e1fab Compare November 17, 2026 13:40
@skjnldsv
skjnldsv merged commit 7119648 into main Nov 17, 2026
41 checks passed
@skjnldsv
skjnldsv deleted the fix/list-consistency branch November 17, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant