Repository navigation
fix(holidays): show employees their own holidays - #228
Merged
Merged
Conversation
Employees saw every region's days, a rule written in region-code jargon and past days looking like upcoming ones. Someone with a region code now opens the page on "Your holidays", the days of their code, its country and everywhere, and reads which those are in one sentence. Without a code the page says only the days for everyone apply and links to the profile to set one. HR keep opening on all regions with a shorter form of the rule, since they keep the list for every region. Days already past in the shown year are muted. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Employees opened Public holidays on every region and got an explanation written in region-code terms. They now open on their own days ("Your holidays (DE-BE)"), with one sentence naming their region and country, and past days are greyed out. Without a region code, they get a link to set it on their profile. HR still opens on all regions.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.