Repository navigation
fix(hr): employees list flags only real gaps - #230
Merged
Merged
Conversation
A person without a manager was flagged as missing data with a warning chip and counted by the "Missing data" filter, although the person at the top and HR legitimately have none. Missing data is now the region code, the working pattern and the start date; no manager reads as muted text. The Since column shows the full date on every row instead of mixing years and dates, and the subtitle names the employees group by its display name, which the list endpoint now returns as employeesGroupName. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"No manager" was a warning chip and counted as missing data, even for the person at the top. It's now plain text. "Missing data" means a missing region, contract or start date. "Since" uses one date format on every row, and the subtitle shows the group's name instead of its id.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.