Skip to content

fix(hr): employees list flags only real gaps - #230

Merged
skjnldsv merged 1 commit into
mainfrom
fix/hr-employees-list
Nov 17, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/hr-employees-list

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

"No manager" was a warning chip and counted as missing data, even for the person at the top. It's now plain text. "Missing data" means a missing region, contract or start date. "Since" uses one date format on every row, and the subtitle shows the group's name instead of its id.

Before After

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

A person without a manager was flagged as missing data with a warning chip
and counted by the "Missing data" filter, although the person at the top
and HR legitimately have none. Missing data is now the region code, the
working pattern and the start date; no manager reads as muted text.

The Since column shows the full date on every row instead of mixing years
and dates, and the subtitle names the employees group by its display name,
which the list endpoint now returns as employeesGroupName.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working AI assisted This PR contains AI-assisted commits labels Nov 17, 2026
@skjnldsv skjnldsv self-assigned this Nov 17, 2026
@skjnldsv
skjnldsv merged commit f407316 into main Nov 17, 2026
48 checks passed
@skjnldsv
skjnldsv deleted the fix/hr-employees-list branch November 17, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant