Repository navigation
fix(requests): answer unknown and hidden requests alike - #237
Merged
Merged
Conversation
…n one The routes of one request (detail, edit, cancel, approve, reject, comment, and the attachment list and upload) answered 404 for an unknown id and 403 for a request the caller may not see. Request ids are sequential, so the difference told how many requests exist. Both now answer 404 "Request not found". HR sees every request, so its answers do not change. A confidential absence shown to someone who does not see its type still named the HR member who recorded it. `decidedBy` is now withheld with the type, so `decidedByName` is left out as well. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request ids are sequential, and a 404 for an unknown id next to a 403 for someone else's request told how many requests exist. Both now answer 404 "Request not found", attachments included. HR's answers don't change. The name of whoever recorded a confidential absence is now also kept from people who don't see its type.
Not covered: download and delete of a single attachment, keyed by attachment id.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.