Skip to content

fix(requests): answer unknown and hidden requests alike - #237

Merged
skjnldsv merged 1 commit into
mainfrom
fix/request-not-found-alike
Nov 17, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/request-not-found-alike

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Request ids are sequential, and a 404 for an unknown id next to a 403 for someone else's request told how many requests exist. Both now answer 404 "Request not found", attachments included. HR's answers don't change. The name of whoever recorded a confidential absence is now also kept from people who don't see its type.

Not covered: download and delete of a single attachment, keyed by attachment id.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

…n one

The routes of one request (detail, edit, cancel, approve, reject, comment,
and the attachment list and upload) answered 404 for an unknown id and 403
for a request the caller may not see. Request ids are sequential, so the
difference told how many requests exist. Both now answer 404 "Request not
found". HR sees every request, so its answers do not change.

A confidential absence shown to someone who does not see its type still
named the HR member who recorded it. `decidedBy` is now withheld with the
type, so `decidedByName` is left out as well.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working AI assisted This PR contains AI-assisted commits labels Nov 17, 2026
@skjnldsv skjnldsv self-assigned this Nov 17, 2026
@skjnldsv
skjnldsv merged commit 14ac169 into main Nov 17, 2026
48 checks passed
@skjnldsv
skjnldsv deleted the fix/request-not-found-alike branch November 17, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant