Skip to content

fix(hr): no entitlement editor on HR's own row - #239

Merged
skjnldsv merged 1 commit into
mainfrom
fix/own-entitlement-editor
Nov 17, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/own-entitlement-editor

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Since #223 the server refuses HR changing their own days, but the editor was still offered and saving showed the refusal. On HR's own profile and Employees row, it now says "Somebody else from HR changes your own days."

Before After

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working AI assisted This PR contains AI-assisted commits labels Nov 17, 2026
@skjnldsv skjnldsv self-assigned this Nov 17, 2026
@skjnldsv
skjnldsv force-pushed the fix/own-entitlement-editor branch from e174fd9 to 58384f7 Compare November 17, 2026 15:20
The server refuses a change to one's own entitlement, but the profile page
and the employees list still offered HR the entitlement editor on their
own row, and saving showed the refusal.

Their own profile and their own employees row now say "Somebody else from
HR changes your own days." instead of offering the editor.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit eb15e5d into main Nov 17, 2026
41 checks passed
@skjnldsv
skjnldsv deleted the fix/own-entitlement-editor branch November 17, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant