Repository navigation
fix(employees): JSON export follows the contract years - #240
Merged
Merged
Conversation
The employees JSON export listed the default entitlement for the current year when no row existed, and the import compared listed years with that default, whatever the contract said. The balance gives no default for a year the contract does not cover. Export and compare now use the same figure as the balance: the default in a year the contract covers, 0 otherwise. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The employees JSON export still listed the default days for years outside someone's contract. Since #221 their balance shows 0 for those years, so a round trip reported changes that weren't there. Export and compare now use the same rule as the balance.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.