Add FileSanitizer, RemotePathUtils, and comprehensive tests#16527
Add FileSanitizer, RemotePathUtils, and comprehensive tests#16527amussara wants to merge 1 commit intonextcloud:masterfrom
Conversation
…unit tests - Add FileSanitizer utility for cross-platform filename sanitization: - Unsafe character replacement (control chars, Windows-reserved chars) - Path traversal detection and bidi character detection/removal - Windows reserved name detection, filename truncation preserving extensions - Unique filename generation with numeric suffixes - Add RemotePathUtils utility for remote path manipulation: - Extract filename, parent path, extension from remote paths - Path depth calculation, joining, normalization - Ancestor path enumeration and folder path detection - Add unit tests for FileSanitizer (30 test cases) - Add unit tests for RemotePathUtils (28 test cases) - Add unit tests for StringExtensions (18 test cases) - Add unit tests for LogEntry parsing edge cases (12 test cases) Signed-off-by: amussara <amussara@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hello Thank you for your contribution and for taking the time to submit this PR. After reviewing the changes, we noticed that some of the logic introduced here overlaps with existing implementations in AutoRename.kt, FileStorageUtils.java, and FileNameValidator.kt. These components already handle the sanitization and modification of remote paths and filenames, which is a particularly critical part of the application. Given the sensitivity of this area and the existing coverage, we are unfortunately not able to merge this PR in its current form. For future contributions, we kindly recommend keeping changes as minimal and focused as possible, along with adding thorough test coverage. This helps us review changes more effectively and ensures stability. We truly appreciate your effort and contribution, thank you again. |
2 participants
2 new Kotlin utility classes + 88 tests across 4 test files. 1,016 lines.