Skip to content

feat(freebsd): support dns lookup - #1209

Merged
kesselb merged 2 commits into
nextcloud:masterfrom
ConstrictM:freebsd-dns
Oct 23, 2026
Merged

kesselb merged 2 commits into
nextcloud:masterfrom
ConstrictM:freebsd-dns

Conversation

@ConstrictM

@ConstrictM ConstrictM commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

FreeBSD uses /etc/resolv.conf for DNS. The logic used in Linux is the same for FreeBSD.

image

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

FreeBSD uses /etc/resolv.conf for DNS. The same logic used in Linux is the same for FreeBSD.

Signed-off-by: Matt <125427297+ConstrictM@users.noreply.github.com>
@kesselb
kesselb enabled auto-merge October 23, 2026 09:28
getNetworkInfo() now reads /etc/resolv.conf, but the FreeBSD test mock
did not stub readContent(), so testGetNetworkInfo read the real file of
whatever machine ran the tests and failed wherever that file lists a
nameserver. The test now stubs it as unreadable, and a second test
checks that nameservers are listed once each, in file order, with
indented lines and comments handled.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
@kesselb
kesselb merged commit 050d473 into nextcloud:master Oct 23, 2026
37 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants