Skip to content

feat(os): collect the operating system status - #1214

Merged
karlitschek merged 80 commits into
masterfrom
feat/os-status-collector
Oct 25, 2026
Merged

karlitschek merged 80 commits into
masterfrom
feat/os-status-collector

Conversation

@karlitschek

@karlitschek karlitschek commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Part 1 of 5, stacked on master:

  1. feat(os): collect the operating system status #1214 – collect the operating system status ← this PR
  2. feat(os): add an optional root helper #1215 – optional root helper
  3. feat(os): support dnf, zypper, pacman and apk #1216 – dnf, zypper, pacman and apk
  4. feat(os): report operating system concerns where admins look #1217 – setup checks, notifications, monitoring API, dashboard widget
  5. feat(os): add the Operating system page #1218 – the Operating system page

AI disclosure: this change was written with Claude Code (claude-opus-5-5) and reviewed by the author; every commit carries an Assisted-by trailer.

🤖 Generated with Claude Code

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this for correctness, security and performance, and deployed the branch to a nextcloud-docker-dev instance (NC 36 dev, PHP 8.5, Debian 13 container) to exercise it. Inline comments carry the details; this is the summary.

Blocking

  1. CI "NPM build" fails: the committed js/serverinfo-main.mjs.license and js/serverinfo-main.mjs.map.license list @vitejs/plugin-vue 6.0.10, while package-lock.json pins 6.0.7. They were generated from a node_modules out of sync with the lock file; npm ci && npm run build regenerates them correctly. The version bump itself is needed for the background job and command to register.
  2. Missing or stale package lists turn into "no security updates" (reproduced): with the image's purged /var/lib/apt/lists, apt-get -s dist-upgrade reported 0 pending updates; after apt-get update the same container reported 71 pending, 35 of them security. The updates concern only becomes unknown when updates === null, so the headline answer is a false all-clear wherever the lists are missing or old (see OsVerdict.php).
  3. occ serverinfo:os-status exit codes do not follow the monitoring-plugin convention it cites: "not checked yet" exits 1 (= WARNING), and an all-unknown verdict reports "level": "ok" and exits 0. In the Docker container 3 of 4 concerns were unknown and the command said OK. Monitoring plugins use 3 for UNKNOWN.

Correctness

  • The first-seen key includes the candidate version, so a superseding security update resets the pending-days counter.
  • CoreLibraryProbe treats an upgraded systemd binary as a reboot reason, though systemd re-executes itself on upgrade; on Debian, which has no /run/reboot-required by default, that is a recurring false positive.
  • In LXC without lxcfs, /proc/uptime is the host's, so a container created after the host booted reports a core-library reboot straight away.
  • Smaller: Thresholds::load() does not enforce warning ≤ error; nixos-unstable is not an os-release ID; Raspbian is mapped to Debian's support dates though it has its own archive; /dev/shm/ is shadowed by /dev/.
  • Worth stating in the UI later: Debian ships many fixes through point releases (libc6 2.41-12+deb13u4 from Debian:13.7/stable in my run), so "0 security updates" does not mean fully patched.

Security

  • CommandRunner is well done: an argument vector to proc_open() with no shell, validated binary names, a fixed PATH, LC_ALL=C, stdin from /dev/null, an output cap and a kill on timeout. All arguments are constants, so I found no injection surface, and restricted_mode is honoured.
  • The risk is exposure rather than execution. In this PR the data is only visible to admins through occ, but a list of unpatched packages with exact versions is an attacker's roadmap. Once #1217 exposes this through the token-authenticated monitoring API, consider returning counts there and keeping the package list admin-only.
  • Package names and origins are stored as parsed from tool output (\S+). Nothing here renders them, but #1218 should not pass them through v-html.
  • The collector reads /proc/1/cgroup, /sys/class/dmi/id/* and queries systemd over D-Bus. Everything degrades to unknown when denied, which is right; the README could list what is read so hardened setups know what to expect.

Performance

  • From system cron this is cheap. A full refresh took 0.75 s in the container; with 71 pending updates, apt-get -s dist-upgrade took 2.3 s and the remaining apt probes 0.4 s.
  • Under AJAX or webcron background-job modes the job runs inside a web request. The timeouts add up to roughly four minutes in the worst case (120 s for apt-get, 3 × 30 s, plus the 10 s and 5 s probes), all holding one PHP-FPM worker. Consider skipping the job unless backgroundjobs_mode is cron, or shortening the timeouts there.
  • The status is stored as a lazy app-config array capped at 500 updates, which fits the long-text column on every supported database.

Comment thread lib/OsStatus/Verdict/OsVerdict.php Resolved
Comment thread lib/Commands/ShowOsStatus.php Resolved
Comment thread lib/Commands/ShowOsStatus.php Resolved
Comment thread lib/OsStatus/Packages/PendingUpdate.php Resolved
Comment thread lib/Jobs/UpdateOsStatus.php Resolved
Comment thread lib/OsStatus/Packages/Apt.php Resolved
Comment thread build/update-os-support.php Resolved
Comment thread lib/OsStatus/Support/SupportTable.php Resolved
@karlitschek
karlitschek force-pushed the feat/os-status-collector branch from b2085c1 to 2e8c497 Compare October 22, 2026 21:32
@karlitschek

Copy link
Copy Markdown
Member Author

@AndyScherzinger Thanks for the review. All should be fixed now

@karlitschek
karlitschek marked this pull request as ready for review October 23, 2026 04:41
@karlitschek
karlitschek force-pushed the feat/os-status-collector branch from 2e8c497 to eb88b3f Compare October 23, 2026 04:41
@karlitschek
karlitschek force-pushed the feat/os-status-collector branch from eb88b3f to 60f5960 Compare October 23, 2026 08:49

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of 60f59603. I deployed the whole stack (up to #1218) to the same nextcloud-docker-dev instance as before (NC 36 dev, PHP 8.5, Debian 13 container, background jobs from system cron) and re-ran the checks.

Verified fixed

  • Missing package lists now make the pending updates unknown instead of an all-clear.
  • occ serverinfo:os-status exits 3 when nothing has been collected yet (live: exit=3), and an unknown verdict also maps to 3.
  • First-seen times are tracked per package, so a superseding update keeps counting.
  • systemd is no longer a core-library reboot reason. A changed file now also needs a package change since boot, and system containers skip the probe.
  • Error thresholds are clamped to their warning thresholds.
  • Collection runs only from system cron, and a new freshness concern warns when the status gets old or cron is not system cron.
  • The status moved to app data. Live: status.json is about 1.2 KB, and the legacy cached_os_status app config key is gone.
  • The license files match the lock file again, and CI is green.

Remaining

One finding is left, inline: in an application container the command still reports ok and exits 0, although the container's own packages have pending security updates.

$known = true;
}

if (Concern::rank($level) <= Concern::rank(Concern::LEVEL_INFO) && $this->get(Concern::UPDATES)?->level === Concern::LEVEL_UNKNOWN) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only turns the level unknown when an UPDATES concern exists and is unknown. In an application container OsVerdict never creates that concern (managesPackages() is false), so the result is ok and exit 0.

Live in the Docker container: occ serverinfo:os-status --refresh gives "level": "ok", "updates": "unknown" and exit 0. Earlier, apt-get -s dist-upgrade in that same container listed 71 pending updates, 35 of them from Debian-Security.

It is a fair design choice that the image's packages are not the admin's to patch in place. But ok/0 is still a claim about them, and monitoring will read it as healthy. I suggest one of:

  • Emit the UPDATES concern as unknown (or a dedicated not-assessed state) in application containers, so that level() and the exit code say unknown.
  • State explicitly in the output and the README that ok covers host-side concerns only.

The same root cause makes the #1217 dashboard widget say "The system is up to date" in this container.

@kesselb

kesselb commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Turning off the update part

  • A switch for the OS-update part only. Where patching is handled elsewhere (Ansible, Landscape, Ubuntu Pro) or does not apply (application containers, images rebuilt by CI/CD), the rest of serverinfo could stay available with this part off. One bool key in ConfigLexicon would do; when it is off, the verdict could say "disabled" rather than "unknown", so occ serverinfo:os-status does not exit 3.
  • It might default to off when Docker or Kubernetes is detected, which would also cover @AndyScherzinger's remaining finding about application containers reporting ok.

Multiple application servers

Setups with two or more application servers are common. The status, the cache key and the first-seen times are currently shared, so the status shows whichever node last ran the job, and the thresholds reset when nodes disagree.

  • Keying the data per node with IServerInfo::getServerId(). It already falls back to a hash of the hostname; admins can set serverid per node to rule out collisions in the 0–511 range.

  • An option to turn off only the background job, so admins can run occ serverinfo:os-status --refresh from each node's own cron. The TimedJob runs on one node per interval only.

  • A table rather than a cache keyed by node: id | serverid | collected_at | last_seen | status | first_seen | php_sample | php_outdated_since

    • collected_at: when this node's status was last collected
    • last_seen: when this node last wrote anything, to spot nodes that stopped reporting and clean up removed ones
    • status: today os-status/status.json plus the cache key status
    • first_seen, php_sample, php_outdated_since: today the cached_os_* app config keys

    A cache can be evicted (and first_seen must survive that), cannot list its nodes, and with only memcache.local configured the cron write never reaches web requests. One row per node also removes the race on first_seen, and one indexed read makes the cache in front of app data unnecessary.

  • Nodes that only serve web requests would get a row with just php_sample and last_seen, shown as "not collected".

It would be good to settle this before #1217 and #1218 land, since it changes the storage format.

Nitpicks

  • 21 of the 22 commits fix the first one, and some undo earlier changes (storage, license files, README), so their messages describe fixes to code that is not on master yet. Could they be squashed into one commit that describes the final design?
  • The PHP-process sampler has no caller here yet. Could it move to feat(os): add the Operating system page #1218, where it is used?

karlitschek and others added 6 commits October 25, 2026 20:17
Collect what keeps the Linux distribution under Nextcloud secure, as far as
the web server user can see it: pending updates with security fixes told
apart (apt), reboots that installed updates wait for (the running kernel
against /lib/modules, core libraries replaced since boot, the distribution's
own flag), libraries replaced under the PHP serving Nextcloud, how long the
release still receives security updates (bundled from endoflife.date by
build/update-os-support.php, nothing fetched at runtime), automatic updates,
held packages, failed system services, time synchronisation and mandatory
access control. Containers, LXC guests and snaps are told apart, so nothing
is claimed that cannot be known from inside.

Commands run through proc_open() with an argument vector, a fixed search
path, LC_ALL=C, a time limit and an output cap. A background job collects
the status hourly. One verdict with configurable thresholds judges it, and
occ serverinfo:os-status shows it, exiting 0/1/2 for monitoring checks.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Without package lists apt-get -s finds no newer versions, which read as
"no security updates". When the lists cannot be found and nothing is
pending, the updates are now unknown, with a diagnostic. Updates found in
lists past the warning age carry a listsStale fact, and occ reports the
security update count as unknown when the updates are.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
occ serverinfo:os-status follows the monitoring-plugin exit codes, where
3 is UNKNOWN. A status that was never collected, could not be collected
or has no verdict now exits 3 instead of 1 or 0. The overall level is
unknown when nothing is wrong but the pending updates are unknown, so an
unknown update state no longer reads as an all-clear.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
A security update superseded by a newer one before it was installed
started a new first-seen entry, so the pending days, and with them the
thresholds, started over. Hosts with frequently updated packages could
stay below the error threshold indefinitely.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
systemd's package re-executes PID 1 on upgrade, so a newer systemd binary
needs no reboot; on Debian, which has no /run/reboot-required by default,
every systemd update became a reboot warning. In a system container
without lxcfs the uptime is the host's, so a container created after the
host booted reported a reboot straight away; the probe now skips system
containers.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
With an error threshold below its warning threshold, a finding went
straight from info to error and the warning stage disappeared. Loading
the thresholds now raises each error value to its warning value.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
karlitschek and others added 26 commits October 25, 2026 20:17
OsNotifier threw AlreadyProcessedException whenever the concern was not
a problem at render time, including when it was unknown, missing from
the verdict, or when the stored status could not be read, for example
after an upgrade changed its format. The notification manager then
deleted that admin's notification, while os_notified_levels still
remembered the level, so it was never sent again.

It is now only dropped when the concern is known and no longer a
problem (Concern::isResolved()), or when the sender has withdrawn it.
Otherwise it renders a generic "The operating system needs attention"
with the link to the page.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Three gaps in OsNotificationSender::sync():

- Admins added to the admin group while a concern was live never got
  its notification, because a concern notified only on escalation.
  Every run now notifies enabled admins who were not notified since
  the last escalation and have no notification of the concern. Who
  was notified is kept in os_notified_users, so an admin who dismissed
  the notification does not get it again until the concern escalates.
- The job and occ serverinfo:os-status --refresh could sync at the
  same time and notify twice. sync() now holds an exclusive lock from
  ILockingProvider and skips when another process holds it. Each admin
  is also checked with IManager::getCount() before a notification, and
  the subject is now the level, so an escalation withdraws only the
  notifications of the other level instead of all of them; a process
  with outdated notified levels therefore re-sends nothing.
- markProcessed() failures escaped and failed the job. Withdrawals are
  now caught and logged, and a concern whose withdrawal failed stays
  remembered so the next run tries again.

A stored status that cannot be read no longer withdraws anything, for
the same reason the notifier keeps such notifications.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
On systems other than Linux and in restricted mode the widget said
"The operating system has not been checked yet." forever, since the
status there is never more than "unsupported" or "restricted".

ServerHealthWidget::isEnabled() now also asks the new
OsStatusService::isApplicable(), which reads restricted_mode and the OS
family but no stored status, so the dashboard stays cheap. Should the
widget still be asked for items, it shows the sentence the setup checks
use; both now come from ConcernTexts::unavailable().

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The stored status is only renewed by the background job under system
cron. When cron stops, or background jobs run by AJAX or webcron, the
Overview and the dashboard kept presenting a weeks-old status as the
current one.

The freshness concern now has its own headline and sentence: how long
ago the system was checked, and either "switch background jobs to
Cron" or "check that the cron job runs". Each setup check appends it
and is at least a warning while the status is old, since all three
judge the same stored status. The widget lists it like the other
concerns. It sends no notification: the job that would send one is
the one that stopped.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
ConcernTexts::title() only told the concerns' known levels apart, so a
concern that could not be determined got the headline of a problem:
"Reboot required" when the reboot state was unknown, "The system clock
is not synchronized" when time sync could not be checked. Setup checks
and the widget skip unknown concerns, but the page shows every concern
with its headline.

Unknown concerns now say what could not be determined, in the words
the page already uses.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The setup checks are the first to sample the PHP process that serves
Nextcloud, so this is where the README can promise that check and name
the process maps it reads.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Core serves GET /settings/setupcheck with #[NoAdminRequired], and the
settings app's sub-admin middleware lets sub-admins through. They got
the full OS setup checks: pending security updates and their age, the
reboot state and the end-of-life status. The widget and notifications
are for admins only, so the endpoint undercut the app's own boundary.

The checks now answer a session user who is not an admin with the same
neutral info result, whatever the system's state, and do not sample
the PHP process for them. occ setupchecks and cron run without a
session user and still get the full result.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Settings → Overview renders a setup check's description with v-html
and escapes only the rich object parameters. The OS checks build their
description from ConcernTexts, which puts strings from the system into
it, such as PRETTY_NAME from /etc/os-release, which is free text. Markup
there ran in an admin's browser.

The checks now escape the text with htmlspecialchars() before adding
the {link} placeholder, which core fills with an escaped link, and on
the success path, which has no link. Quotes are left alone: the text is
never put into an attribute, and occ setupchecks prints the description
without decoding entities, so translations with apostrophes stay
readable there. Only <, > and & show as entities in occ.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
…er admins

OsNotifier builds the text from the current status every time the
notification is fetched, and the sender withdraws a notification only
when its concern resolves. An admin who was removed from the admin
group kept getting live security update counts, reboot and end-of-life
state through notifications sent while they were an admin.

prepare() now throws AlreadyProcessedException when the recipient is
not an admin, so the notification is deleted before anything from the
status is read.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
PhpProcessProbe::canSample() only looks at the SAPI, so the setup
checks still read /proc/self/maps, /proc/self/exe and the confinement
files, and stored a sample, with restricted_mode=yes, although the
collector honours the setting and the README promises that restricted
mode stops reads outside the app directory.

samplePhpProcess() now returns before any read or store access when
isApplicable() is false: in restricted mode or on a system other than
Linux. FakeHost records the paths it is asked to read, so the test can
show that nothing was read.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
A fourth page in the Monitoring settings: the verdict at a glance, pending
updates with the packages Nextcloud runs on marked, reboot and restart
findings with the commands to copy, release support, maintenance, system
health and root helper setup. Alert thresholds and notifications are set in
a dialog. The Status page links to it when something needs attention.

The filter pills of the Database page are now a shared component. Frontend
tests run with Vitest.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
"Check now" ran the whole collection inside the POST request. The
package manager timeouts allow minutes, so behind a proxy timeout the
browser saw an error while PHP kept running, and several admins, tabs
or the cron job could run dnf or zypper in parallel.

The request now only queues a RefreshOsStatus job and answers 202. The
page shows that a check is running and polls GET /os, at a growing
interval and for at most 15 minutes, until collectedAt changes. Every
request has a 30 second timeout. A page that loads while a check is
queued or running follows it as well.

collectAndStore() takes an exclusive lock through ILockingProvider, so
the hourly job, the queued job and occ never collect at the same time.
POST /os/refresh answers 409 while the lock is held, and occ --refresh
says so instead of pointing to the log.

The queued job runs only from system cron, like UpdateOsStatus: under
AJAX or webcron it would run inside a web request and hold a web server
worker for minutes. Without system cron the endpoint answers 409 and the
page disables the button and points to occ serverinfo:os-status
--refresh instead.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The setup dialog copied the helper from the live app directory and said
that this protects against a compromised web server. It does not: the
web server can write to that directory, so it can replace the script
before root copies it, and the "helper outdated" prompt asks for that
copy after every update.

The dialog now tells admins to install the script from a freshly
downloaded and extracted release of the app or of Nextcloud, and its
command copies bin/serverinfo-os-report relative to that directory.
The payload no longer carries the path inside the app directory, which
nothing uses any more.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The page built "sudo systemctl restart <unit>" itself and always offered
"sudo systemctl reboot". On Alpine, where services run under OpenRC, both
were wrong, and unit names were not shell-quoted, so an escaped name such
as "foo\x2dbar" lost its backslash when pasted.

The server now sends the commands with the status, like the upgrade
commands: systemctl when systemd runs (/run/systemd/system), rc-service
and reboot under OpenRC (/run/openrc), and none when the init system
cannot be told. Unit names are quoted for a POSIX shell. Without a
command the page names the service or asks for a reboot in words.

The health section no longer says "systemd is not available" on systems
that do not use systemd, and offers timedatectl only with systemd.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The updates table started on the security filter whenever the package
manager classifies updates, so a system with no security update but 40
others showed an empty table under the tiles. The filter was also chosen
only once and kept after a new check, even when the new list had nothing
under it.

The table now starts on "All" when there is no security update, chooses
again when a check brings a new status, and says so in a row of its own
when a filter matches nothing. The spec for this case now checks the
rows instead of only the hint below the table.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
updateSettings() declared "bool $notifications" and "array $thresholds"
without defaults, so a request that left one out failed with a
TypeError and a 500. Both are now optional in the signature and checked
in the method, which answers 400 with the name of the missing field.

The dialog had its own copy of the defaults, the 3650-day limit and the
warning/error pairs from Thresholds. The payload now carries them, and
the dialog validates and restores defaults from it. "Restore defaults"
also turns notifications back on, which is their default.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The Operating system page brought Vitest specs and "npm test", but no
workflow ran them, so they never ran on a pull request. This adds the
organization's node-test workflow template unchanged; it runs
"npm run test", which is "vitest run".

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The page wrote its own concern titles, reboot reasons, support sentences
and the names of the extended support programmes, which ConcernTexts
already writes for the setup checks, notifications and the widget. The
two copies had already drifted apart ("components" against "libraries").

OsController now adds each concern's title and detail, rendered by
ConcernTexts in the admin's language, to the payload. The page shows
them in the summary chips, the reboot item, release support, failed
services and the clock check. The JavaScript copies and their
translation strings are gone; Verdict::toArray(), which only the old
payload used, is gone too.

The page keeps its own words where ConcernTexts has none: for states
that could not be determined, for the specifics of each reboot reason
(the new kernel version, the updated packages) and for the restart
items, which describe the PHP process and the helper's list rather than
the restart concern.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Small things on the Operating system page:

- Os::getOSName() read /etc/os-release itself. It now reads it through
  IHost, like the collector, with the same /usr/lib/os-release fallback
  and the same open_basedir handling.
- The unsupported-system note said "This server runs {os}" with only
  the kernel release, e.g. "This server runs 14.1-RELEASE" on FreeBSD.
  The payload now carries the system's name for that case.
- FilterPills used a <nav> landmark for a group of toggle buttons; it is
  now a labelled role="group". The Database page uses the same component
  and is unchanged otherwise.
- t() and n() escape placeholder values as HTML and sanitize the result
  by default, but Vue's text interpolation escapes again, so an "&" in a
  path or tool name showed as "&amp;". The page's translations with
  placeholders now pass { escape: false, sanitize: false }; escape alone
  is not enough in @nextcloud/l10n 3.4, whose DOMPurify pass still
  rewrites text that looks like markup.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The page put "Checked 3 weeks ago" in small print under a green
verdict when cron had stopped, and only said that "Check now" needs
system cron, not that everything shown may be out of date.

A freshness warning now shows the server's sentence for it in a note
under the verdict, with the occ command when background jobs do not
run from system cron; that note replaces the separate "Check now needs
system cron" note, so the page does not say it twice. The root helper
section also names the new clock-skew state: a report dated in the
future, which is not used.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The helper's documented cron line passes --random-delay so that
servers sharing it do not all reach the package mirrors at the same
minute; the setup dialog still showed the line without it.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The alert settings decide whether anything about the operating system
is ever reported: with notifications off and every threshold raised to
the maximum, pending security updates, reboots and an unsupported
release all show as fine. A hijacked admin session could do that
silently with one PUT to /os/settings.

updateSettings now carries #[PasswordConfirmationRequired], as the
database connection settings of this app already do. The settings
dialog asks for the password with confirmPassword() from
@nextcloud/password-confirmation before it saves, so an admin whose
last confirmation has expired gets the prompt instead of a failed
save. Closing the prompt leaves the dialog open with the form as it
was and saves nothing.

The package is new to the app; its own dependencies are all already
in the tree. Vitest inlines it like @nextcloud/vue because it imports
CSS that Node cannot load.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
The setup dialog told admins to run sudo install on
bin/serverinfo-os-report relative to wherever they stood. Run from
/var/www, that is the live install, which the web server user owns and
can swap between extracting and installing; root then runs the swapped
script from cron.

The install command now extracts only the helper from the Nextcloud
release archive into a new directory from mktemp -d, which only the
admin can enter, installs it from there and removes the directory. It
is the procedure the README describes.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
@karlitschek
karlitschek force-pushed the feat/os-status-collector branch from 6d327c2 to 34014ec Compare October 25, 2026 19:19
@karlitschek
karlitschek merged commit 68f8296 into master Oct 25, 2026
41 checks passed
@karlitschek
karlitschek deleted the feat/os-status-collector branch October 25, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants