Skip to content

split subworkflow/test_lint into separate files#3965

Merged
mashehu merged 4 commits intonf-core:devfrom
mashehu:split-sbwf-test_lint
Apr 14, 2026
Merged

split subworkflow/test_lint into separate files#3965
mashehu merged 4 commits intonf-core:devfrom
mashehu:split-sbwf-test_lint

Conversation

@mashehu
Copy link
Copy Markdown
Contributor

@mashehu mashehu commented Dec 10, 2025

first commit takes the same tests as in tests/subworkflows/test_lint.py and distributes them over several files (similar to how we have it for tests/modules/lint.
In the second commit i removed unnecessary clean up and combined similar steps into setUp steps

@mashehu mashehu requested a review from mirpedrol December 10, 2025 12:27
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.08%. Comparing base (854fdc9) to head (5f4eac2).
⚠️ Report is 2 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu added this to the 4.0.0 milestone Mar 31, 2026
Copy link
Copy Markdown
Contributor

@JulianFlesch JulianFlesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests found and ran successfully.

test_subworkflows_lint_fix was added as well?

@mashehu mashehu force-pushed the split-sbwf-test_lint branch from c9026c5 to 07f4cf7 Compare April 14, 2026 09:28
@mashehu mashehu merged commit 9c3578d into nf-core:dev Apr 14, 2026
116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants