[feat] Update indices table

[sbreitbart-NOAA]

As per #273

@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?

[github-actions]

New version checklist

• Package version in DESCRIPTION has been updated
• Release notes have been drafted/published
• Cheatsheet content has been updated (if applicable)
• Cheatsheet version has been updated

[github-actions]

Code Metrics Report

Coverage	Code to Test Ratio	Test Execution Time
67.0%	1:0.1	5m24s

Code coverage of files in pull request scope (95.8%)

Files	Coverage
R/table_indices.R	95.8%

---

Reported by octocov

[Schiano-NOAA]

As per #273

@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?

I can't remember where it is, but there is a point in the workflow (I want to say during process_table) where I had to change values from numeric to character in order to keep the trailing zeros. I would suggest doing it right after that step since I think what you are implying, the commas are being placed on a character?

[sbreitbart-NOAA]

As per #273
@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?

I can't remember where it is, but there is a point in the workflow (I want to say during process_table) where I had to change values from numeric to character in order to keep the trailing zeros. I would suggest doing it right after that step since I think what you are implying, the commas are being placed on a character?

Yes! Thanks- found it in process_table(). If that change looks good to you, I'll merge.

[Schiano-NOAA]

@sbreitbart-NOAA this isn't working with BAM models, so I am checking on a fix for it in a sec. Did you test it for Rceattle as well? Also, could you change the name from plot_indices to plot_index? I need to make this change in the naming conventions in the converter as well and will also be for the label.

[sbreitbart-NOAA]

@Schiano-NOAA This isn't working for Rceattle. I'll work on fixing the function name first

[Schiano-NOAA]

@sbreitbart-NOAA plot_indices was working for Rceattle when I was working on the converter (if that helps). I used that as a comparison to the Rceattle::plot_index function to make sure values were correctly converted and the plots looked the same

[Schiano-NOAA]

@sbreitbart-NOAA do you want me to change the naming in the excel files for the converter? I remember you saying you don't have excel locally

[sbreitbart-NOAA]

@sbreitbart-NOAA do you want me to change the naming in the excel files for the converter? I remember you saying you don't have excel locally

I can change them with find/replace. Wasn't sure if those should be updated but now that I know, I can change the other instances of "indices" downstream 👍

[Schiano-NOAA]

@sbreitbart-NOAA great thank you! I also just put out a release (sorry for the multiple emails, I messed up the first ~couple ~ times lol). Could you also update the version in this PR to .9000 since this will probably be the first one for the next release?